Skip to content

Commit cf55a7a

Browse files
mikkorapeli-linarostorulf
authored andcommitted
mmc: core: Avoid negative index with array access
Commit 4d0c8d0 ("mmc: core: Use mrq.sbc in close-ended ffu") assigns prev_idata = idatas[i - 1], but doesn't check that the iterator i is greater than zero. Let's fix this by adding a check. Fixes: 4d0c8d0 ("mmc: core: Use mrq.sbc in close-ended ffu") Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/ Cc: stable@vger.kernel.org Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> Reviewed-by: Avri Altman <avri.altman@wdc.com> Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> Link: https://lore.kernel.org/r/20240313133744.2405325-2-mikko.rapeli@linaro.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 0cdfe5b commit cf55a7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mmc/core/block.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card *card, struct mmc_blk_data *md,
488488
if (idata->flags & MMC_BLK_IOC_DROP)
489489
return 0;
490490

491-
if (idata->flags & MMC_BLK_IOC_SBC)
491+
if (idata->flags & MMC_BLK_IOC_SBC && i > 0)
492492
prev_idata = idatas[i - 1];
493493

494494
/*

0 commit comments

Comments
 (0)