Skip to content

Commit cf60af0

Browse files
abhijitG-xlnxgregkh
authored andcommitted
cdx: Create resource debugfs file for cdx device
resource debugfs file contains host addresses of CDX device resources. Each line of the resource file describe type of resource, a region with start-end and flag fields. Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com> Link: https://lore.kernel.org/r/20231222064627.2828960-2-abhijit.gangurde@amd.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent aeda33a commit cf60af0

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed

drivers/cdx/cdx.c

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
#include <linux/cdx/cdx_bus.h>
6868
#include <linux/iommu.h>
6969
#include <linux/dma-map-ops.h>
70+
#include <linux/debugfs.h>
7071
#include "cdx.h"
7172

7273
/* Default DMA mask for devices on a CDX bus */
@@ -77,6 +78,8 @@
7778
static DEFINE_IDA(cdx_controller_ida);
7879
/* Lock to protect controller ops */
7980
static DEFINE_MUTEX(cdx_controller_lock);
81+
/* Debugfs dir for cdx bus */
82+
static struct dentry *cdx_debugfs_dir;
8083

8184
static char *compat_node_name = "xlnx,versal-net-cdx";
8285

@@ -151,6 +154,7 @@ static int cdx_unregister_device(struct device *dev,
151154
cdx->ops->bus_disable(cdx, cdx_dev->bus_num);
152155
} else {
153156
cdx_destroy_res_attr(cdx_dev, MAX_CDX_DEV_RESOURCES);
157+
debugfs_remove_recursive(cdx_dev->debugfs_dir);
154158
kfree(cdx_dev->driver_override);
155159
cdx_dev->driver_override = NULL;
156160
}
@@ -554,6 +558,31 @@ static const struct attribute_group *cdx_dev_groups[] = {
554558
NULL,
555559
};
556560

561+
static int cdx_debug_resource_show(struct seq_file *s, void *data)
562+
{
563+
struct cdx_device *cdx_dev = s->private;
564+
int i;
565+
566+
for (i = 0; i < MAX_CDX_DEV_RESOURCES; i++) {
567+
struct resource *res = &cdx_dev->res[i];
568+
569+
seq_printf(s, "%pr\n", res);
570+
}
571+
572+
return 0;
573+
}
574+
DEFINE_SHOW_ATTRIBUTE(cdx_debug_resource);
575+
576+
static void cdx_device_debugfs_init(struct cdx_device *cdx_dev)
577+
{
578+
cdx_dev->debugfs_dir = debugfs_create_dir(dev_name(&cdx_dev->dev), cdx_debugfs_dir);
579+
if (IS_ERR(cdx_dev->debugfs_dir))
580+
return;
581+
582+
debugfs_create_file("resource", 0444, cdx_dev->debugfs_dir, cdx_dev,
583+
&cdx_debug_resource_fops);
584+
}
585+
557586
static ssize_t rescan_store(const struct bus_type *bus,
558587
const char *buf, size_t count)
559588
{
@@ -803,6 +832,8 @@ int cdx_device_add(struct cdx_dev_params *dev_params)
803832
}
804833
}
805834

835+
cdx_device_debugfs_init(cdx_dev);
836+
806837
return 0;
807838
resource_create_fail:
808839
cdx_destroy_res_attr(cdx_dev, i);
@@ -907,6 +938,12 @@ EXPORT_SYMBOL_NS_GPL(cdx_unregister_controller, CDX_BUS_CONTROLLER);
907938

908939
static int __init cdx_bus_init(void)
909940
{
910-
return bus_register(&cdx_bus_type);
941+
int ret;
942+
943+
ret = bus_register(&cdx_bus_type);
944+
if (!ret)
945+
cdx_debugfs_dir = debugfs_create_dir(cdx_bus_type.name, NULL);
946+
947+
return ret;
911948
}
912949
postcore_initcall(cdx_bus_init);

include/linux/cdx/cdx_bus.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ struct cdx_controller {
113113
* @dev_num: Device number for this device
114114
* @res: array of MMIO region entries
115115
* @res_attr: resource binary attribute
116+
* @debugfs_dir: debugfs directory for this device
116117
* @res_count: number of valid MMIO regions
117118
* @dma_mask: Default DMA mask
118119
* @flags: CDX device flags
@@ -136,6 +137,7 @@ struct cdx_device {
136137
u8 dev_num;
137138
struct resource res[MAX_CDX_DEV_RESOURCES];
138139
struct bin_attribute *res_attr[MAX_CDX_DEV_RESOURCES];
140+
struct dentry *debugfs_dir;
139141
u8 res_count;
140142
u64 dma_mask;
141143
u16 flags;

0 commit comments

Comments
 (0)