Skip to content

Commit cf6c8ae

Browse files
committed
Merge branch 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
Pull i2c fixes from Wolfram Sang: "A set of driver fixes for the I2C subsystem" * 'i2c/for-current-fixed' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: s3c2410: Mark expected switch fall-through i2c: at91: fix clk_offset for sama5d2 i2c: at91: disable TXRDY interrupt after sending data i2c: iproc: Fix i2c master read more than 63 bytes eeprom: at24: make spd world-readable again
2 parents 8b7fd67 + 8eb9a2d commit cf6c8ae

File tree

5 files changed

+14
-10
lines changed

5 files changed

+14
-10
lines changed

drivers/i2c/busses/i2c-at91-core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ static struct at91_twi_pdata sama5d4_config = {
142142

143143
static struct at91_twi_pdata sama5d2_config = {
144144
.clk_max_div = 7,
145-
.clk_offset = 4,
145+
.clk_offset = 3,
146146
.has_unre_flag = true,
147147
.has_alt_cmd = true,
148148
.has_hold_field = true,

drivers/i2c/busses/i2c-at91-master.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,11 @@ static void at91_twi_write_next_byte(struct at91_twi_dev *dev)
122122
writeb_relaxed(*dev->buf, dev->base + AT91_TWI_THR);
123123

124124
/* send stop when last byte has been written */
125-
if (--dev->buf_len == 0)
125+
if (--dev->buf_len == 0) {
126126
if (!dev->use_alt_cmd)
127127
at91_twi_write(dev, AT91_TWI_CR, AT91_TWI_STOP);
128+
at91_twi_write(dev, AT91_TWI_IDR, AT91_TWI_TXRDY);
129+
}
128130

129131
dev_dbg(dev->dev, "wrote 0x%x, to go %zu\n", *dev->buf, dev->buf_len);
130132

@@ -542,9 +544,8 @@ static int at91_do_twi_transfer(struct at91_twi_dev *dev)
542544
} else {
543545
at91_twi_write_next_byte(dev);
544546
at91_twi_write(dev, AT91_TWI_IER,
545-
AT91_TWI_TXCOMP |
546-
AT91_TWI_NACK |
547-
AT91_TWI_TXRDY);
547+
AT91_TWI_TXCOMP | AT91_TWI_NACK |
548+
(dev->buf_len ? AT91_TWI_TXRDY : 0));
548549
}
549550
}
550551

drivers/i2c/busses/i2c-bcm-iproc.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -392,16 +392,18 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c,
392392
static void bcm_iproc_i2c_read_valid_bytes(struct bcm_iproc_i2c_dev *iproc_i2c)
393393
{
394394
struct i2c_msg *msg = iproc_i2c->msg;
395+
uint32_t val;
395396

396397
/* Read valid data from RX FIFO */
397398
while (iproc_i2c->rx_bytes < msg->len) {
398-
if (!((iproc_i2c_rd_reg(iproc_i2c, M_FIFO_CTRL_OFFSET) >> M_FIFO_RX_CNT_SHIFT)
399-
& M_FIFO_RX_CNT_MASK))
399+
val = iproc_i2c_rd_reg(iproc_i2c, M_RX_OFFSET);
400+
401+
/* rx fifo empty */
402+
if (!((val >> M_RX_STATUS_SHIFT) & M_RX_STATUS_MASK))
400403
break;
401404

402405
msg->buf[iproc_i2c->rx_bytes] =
403-
(iproc_i2c_rd_reg(iproc_i2c, M_RX_OFFSET) >>
404-
M_RX_DATA_SHIFT) & M_RX_DATA_MASK;
406+
(val >> M_RX_DATA_SHIFT) & M_RX_DATA_MASK;
405407
iproc_i2c->rx_bytes++;
406408
}
407409
}

drivers/i2c/busses/i2c-s3c2410.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -435,6 +435,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat)
435435
* fall through to the write state, as we will need to
436436
* send a byte as well
437437
*/
438+
/* Fall through */
438439

439440
case STATE_WRITE:
440441
/*

drivers/misc/eeprom/at24.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ static int at24_probe(struct i2c_client *client)
685685
nvmem_config.name = dev_name(dev);
686686
nvmem_config.dev = dev;
687687
nvmem_config.read_only = !writable;
688-
nvmem_config.root_only = true;
688+
nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
689689
nvmem_config.owner = THIS_MODULE;
690690
nvmem_config.compat = true;
691691
nvmem_config.base_dev = dev;

0 commit comments

Comments
 (0)