mlxsw: switchx2: Remove unnecessary conversion to bool

idosch · davem330 · commit cfe9701a25ce · 2020-03-27T15:06:43.000-07:00
Suppress following warning from coccinelle:

drivers/net/ethernet/mellanox/mlxsw//switchx2.c:183:63-68: WARNING:
conversion to bool not needed here

Signed-off-by: Ido Schimmel &lt;idosch@mellanox.com&gt;
Reviewed-by: Jiri Pirko &lt;jiri@mellanox.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c
@@ -180,7 +180,7 @@ static int mlxsw_sx_port_oper_status_get(struct mlxsw_sx_port *mlxsw_sx_port,
 	if (err)
 		return err;
 	oper_status = mlxsw_reg_paos_oper_status_get(paos_pl);
-	*p_is_up = oper_status == MLXSW_PORT_ADMIN_STATUS_UP ? true : false;
+	*p_is_up = oper_status == MLXSW_PORT_ADMIN_STATUS_UP;
 	return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ static int mlxsw_sx_port_oper_status_get(struct mlxsw_sx_port *mlxsw_sx_port,`
`180`	`180`	`if (err)`
`181`	`181`	`return err;`
`182`	`182`	`oper_status = mlxsw_reg_paos_oper_status_get(paos_pl);`
`183`		`- *p_is_up = oper_status == MLXSW_PORT_ADMIN_STATUS_UP ? true : false;`
	`183`	`+ *p_is_up = oper_status == MLXSW_PORT_ADMIN_STATUS_UP;`
`184`	`184`	`return 0;`
`185`	`185`	`}`
`186`	`186`