Skip to content

Commit d12b3dc

Browse files
arndbkuba-moo
authored andcommitted
net: pse-pd: pd692x0: reduce stack usage in pd692x0_setup_pi_matrix
The pd692x0_manager array in this function is really too big to fit on the stack, though this never triggered a warning until a recent patch made it slightly bigger: drivers/net/pse-pd/pd692x0.c: In function 'pd692x0_setup_pi_matrix': drivers/net/pse-pd/pd692x0.c:1210:1: error: the frame size of 1584 bytes is larger than 1536 bytes [-Werror=frame-larger-than=] Change the function to dynamically allocate the array here. Fixes: 3597540 ("net: pse-pd: pd692x0: Add support for PSE PI priority feature") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Kory Maincent <kory.maincent@bootlin.com> Link: https://patch.msgid.link/20250709153210.1920125-1-arnd@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent acd7c71 commit d12b3dc

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/net/pse-pd/pd692x0.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,7 @@ pd692x0_of_get_ports_manager(struct pd692x0_priv *priv,
860860

861861
static int
862862
pd692x0_of_get_managers(struct pd692x0_priv *priv,
863-
struct pd692x0_manager manager[PD692X0_MAX_MANAGERS])
863+
struct pd692x0_manager *manager)
864864
{
865865
struct device_node *managers_node, *node;
866866
int ret, nmanagers, i, j;
@@ -1164,7 +1164,7 @@ pd692x0_write_ports_matrix(struct pd692x0_priv *priv,
11641164

11651165
static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev)
11661166
{
1167-
struct pd692x0_manager manager[PD692X0_MAX_MANAGERS] = {0};
1167+
struct pd692x0_manager *manager __free(kfree) = NULL;
11681168
struct pd692x0_priv *priv = to_pd692x0_priv(pcdev);
11691169
struct pd692x0_matrix port_matrix[PD692X0_MAX_PIS];
11701170
int ret, i, j, nmanagers;
@@ -1174,6 +1174,10 @@ static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev)
11741174
priv->fw_state != PD692X0_FW_COMPLETE)
11751175
return 0;
11761176

1177+
manager = kcalloc(PD692X0_MAX_MANAGERS, sizeof(*manager), GFP_KERNEL);
1178+
if (!manager)
1179+
return -ENOMEM;
1180+
11771181
ret = pd692x0_of_get_managers(priv, manager);
11781182
if (ret < 0)
11791183
return ret;

0 commit comments

Comments
 (0)