Skip to content

Commit d17a2fe

Browse files
LorenzoBianconinbd168
authored andcommitted
wifi: mt76: mt7921: rely on shared poll_list field
Rely on poll_list field in mt76_wcid structure and get rid of private copy. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Felix Fietkau <nbd@nbd.name>
1 parent e3b0311 commit d17a2fe

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

drivers/net/wireless/mediatek/mt76/mt7921/mac.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ static void mt7921_mac_sta_poll(struct mt7921_dev *dev)
8484
break;
8585
}
8686
msta = list_first_entry(&sta_poll_list,
87-
struct mt7921_sta, poll_list);
88-
list_del_init(&msta->poll_list);
87+
struct mt7921_sta, wcid.poll_list);
88+
list_del_init(&msta->wcid.poll_list);
8989
spin_unlock_bh(&dev->mt76.sta_poll_lock);
9090

9191
idx = msta->wcid.idx;
@@ -281,8 +281,8 @@ mt7921_mac_fill_rx(struct mt7921_dev *dev, struct sk_buff *skb)
281281
if (status->wcid) {
282282
msta = container_of(status->wcid, struct mt7921_sta, wcid);
283283
spin_lock_bh(&dev->mt76.sta_poll_lock);
284-
if (list_empty(&msta->poll_list))
285-
list_add_tail(&msta->poll_list,
284+
if (list_empty(&msta->wcid.poll_list))
285+
list_add_tail(&msta->wcid.poll_list,
286286
&dev->mt76.sta_poll_list);
287287
spin_unlock_bh(&dev->mt76.sta_poll_lock);
288288
}
@@ -568,8 +568,8 @@ void mt7921_mac_add_txs(struct mt7921_dev *dev, void *data)
568568
goto out;
569569

570570
spin_lock_bh(&dev->mt76.sta_poll_lock);
571-
if (list_empty(&msta->poll_list))
572-
list_add_tail(&msta->poll_list, &dev->mt76.sta_poll_list);
571+
if (list_empty(&msta->wcid.poll_list))
572+
list_add_tail(&msta->wcid.poll_list, &dev->mt76.sta_poll_list);
573573
spin_unlock_bh(&dev->mt76.sta_poll_lock);
574574

575575
out:
@@ -649,8 +649,8 @@ static void mt7921_mac_tx_free(struct mt7921_dev *dev, void *data, int len)
649649

650650
msta = container_of(wcid, struct mt7921_sta, wcid);
651651
spin_lock_bh(&mdev->sta_poll_lock);
652-
if (list_empty(&msta->poll_list))
653-
list_add_tail(&msta->poll_list,
652+
if (list_empty(&msta->wcid.poll_list))
653+
list_add_tail(&msta->wcid.poll_list,
654654
&mdev->sta_poll_list);
655655
spin_unlock_bh(&mdev->sta_poll_lock);
656656
continue;

drivers/net/wireless/mediatek/mt76/mt7921/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ static int mt7921_add_interface(struct ieee80211_hw *hw,
313313

314314
idx = MT7921_WTBL_RESERVED - mvif->mt76.idx;
315315

316-
INIT_LIST_HEAD(&mvif->sta.poll_list);
316+
INIT_LIST_HEAD(&mvif->sta.wcid.poll_list);
317317
mvif->sta.wcid.idx = idx;
318318
mvif->sta.wcid.phy_idx = mvif->mt76.band_idx;
319319
mvif->sta.wcid.hw_key_idx = -1;
@@ -358,8 +358,8 @@ static void mt7921_remove_interface(struct ieee80211_hw *hw,
358358
mt7921_mutex_release(dev);
359359

360360
spin_lock_bh(&dev->mt76.sta_poll_lock);
361-
if (!list_empty(&msta->poll_list))
362-
list_del_init(&msta->poll_list);
361+
if (!list_empty(&msta->wcid.poll_list))
362+
list_del_init(&msta->wcid.poll_list);
363363
spin_unlock_bh(&dev->mt76.sta_poll_lock);
364364

365365
mt76_packet_id_flush(&dev->mt76, &msta->wcid);
@@ -764,7 +764,7 @@ int mt7921_mac_sta_add(struct mt76_dev *mdev, struct ieee80211_vif *vif,
764764
if (idx < 0)
765765
return -ENOSPC;
766766

767-
INIT_LIST_HEAD(&msta->poll_list);
767+
INIT_LIST_HEAD(&msta->wcid.poll_list);
768768
msta->vif = mvif;
769769
msta->wcid.sta = 1;
770770
msta->wcid.idx = idx;
@@ -843,8 +843,8 @@ void mt7921_mac_sta_remove(struct mt76_dev *mdev, struct ieee80211_vif *vif,
843843
}
844844

845845
spin_lock_bh(&dev->mt76.sta_poll_lock);
846-
if (!list_empty(&msta->poll_list))
847-
list_del_init(&msta->poll_list);
846+
if (!list_empty(&msta->wcid.poll_list))
847+
list_del_init(&msta->wcid.poll_list);
848848
spin_unlock_bh(&dev->mt76.sta_poll_lock);
849849

850850
mt76_connac_power_save_sched(&dev->mphy, &dev->pm);

drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ struct mt7921_sta {
150150

151151
struct mt7921_vif *vif;
152152

153-
struct list_head poll_list;
154153
u32 airtime_ac[8];
155154

156155
int ack_signal;

0 commit comments

Comments
 (0)