bcachefs: Fix failure to flush moves before sleeping in copygc

Kent Overstreet · Kent Overstreet · commit d3204616a67e · 2024-08-24T10:16:21.000-04:00
This fixes an apparent deadlock - rebalance would get stuck trying to
take nocow locks because they weren't being released by copygc.

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/movinggc.c b/fs/bcachefs/movinggc.c
@@ -383,7 +383,7 @@ static int bch2_copygc_thread(void *arg)
 			if (min_member_capacity == U64_MAX)
 				min_member_capacity = 128 * 2048;
 
-			bch2_trans_unlock_long(ctxt.trans);
+			move_buckets_wait(&ctxt, buckets, true);
 			bch2_kthread_io_clock_wait(clock, last + (min_member_capacity >> 6),
 					MAX_SCHEDULE_TIMEOUT);
 		}

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ static int bch2_copygc_thread(void *arg)`
`383`	`383`	`if (min_member_capacity == U64_MAX)`
`384`	`384`	`min_member_capacity = 128 * 2048;`
`385`	`385`
`386`		`- bch2_trans_unlock_long(ctxt.trans);`
	`386`	`+ move_buckets_wait(&ctxt, buckets, true);`
`387`	`387`	`bch2_kthread_io_clock_wait(clock, last + (min_member_capacity >> 6),`
`388`	`388`	`MAX_SCHEDULE_TIMEOUT);`
`389`	`389`	`}`