Skip to content

Commit d3b8877

Browse files
fltorobclark
authored andcommitted
drm/msm: add msm_gem_get_and_pin_iova_range
This function allows pinning iova to a specific page range (for a6xx GMU). Signed-off-by: Jonathan Marek <jonathan@marek.ca> Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org> Signed-off-by: Rob Clark <robdclark@chromium.org>
1 parent eadf792 commit d3b8877

File tree

3 files changed

+30
-10
lines changed

3 files changed

+30
-10
lines changed

drivers/gpu/drm/msm/msm_drv.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,8 @@ int msm_crtc_enable_vblank(struct drm_crtc *crtc);
237237
void msm_crtc_disable_vblank(struct drm_crtc *crtc);
238238

239239
int msm_gem_init_vma(struct msm_gem_address_space *aspace,
240-
struct msm_gem_vma *vma, int npages);
240+
struct msm_gem_vma *vma, int npages,
241+
u64 range_start, u64 range_end);
241242
void msm_gem_purge_vma(struct msm_gem_address_space *aspace,
242243
struct msm_gem_vma *vma);
243244
void msm_gem_unmap_vma(struct msm_gem_address_space *aspace,
@@ -277,6 +278,9 @@ vm_fault_t msm_gem_fault(struct vm_fault *vmf);
277278
uint64_t msm_gem_mmap_offset(struct drm_gem_object *obj);
278279
int msm_gem_get_iova(struct drm_gem_object *obj,
279280
struct msm_gem_address_space *aspace, uint64_t *iova);
281+
int msm_gem_get_and_pin_iova_range(struct drm_gem_object *obj,
282+
struct msm_gem_address_space *aspace, uint64_t *iova,
283+
u64 range_start, u64 range_end);
280284
int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
281285
struct msm_gem_address_space *aspace, uint64_t *iova);
282286
uint64_t msm_gem_iova(struct drm_gem_object *obj,

drivers/gpu/drm/msm/msm_gem.c

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,8 @@ put_iova(struct drm_gem_object *obj)
389389
}
390390

391391
static int msm_gem_get_iova_locked(struct drm_gem_object *obj,
392-
struct msm_gem_address_space *aspace, uint64_t *iova)
392+
struct msm_gem_address_space *aspace, uint64_t *iova,
393+
u64 range_start, u64 range_end)
393394
{
394395
struct msm_gem_object *msm_obj = to_msm_bo(obj);
395396
struct msm_gem_vma *vma;
@@ -404,7 +405,8 @@ static int msm_gem_get_iova_locked(struct drm_gem_object *obj,
404405
if (IS_ERR(vma))
405406
return PTR_ERR(vma);
406407

407-
ret = msm_gem_init_vma(aspace, vma, obj->size >> PAGE_SHIFT);
408+
ret = msm_gem_init_vma(aspace, vma, obj->size >> PAGE_SHIFT,
409+
range_start, range_end);
408410
if (ret) {
409411
del_vma(vma);
410412
return ret;
@@ -443,17 +445,22 @@ static int msm_gem_pin_iova(struct drm_gem_object *obj,
443445
msm_obj->sgt, obj->size >> PAGE_SHIFT);
444446
}
445447

446-
/* get iova and pin it. Should have a matching put */
447-
int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
448-
struct msm_gem_address_space *aspace, uint64_t *iova)
448+
/*
449+
* get iova and pin it. Should have a matching put
450+
* limits iova to specified range (in pages)
451+
*/
452+
int msm_gem_get_and_pin_iova_range(struct drm_gem_object *obj,
453+
struct msm_gem_address_space *aspace, uint64_t *iova,
454+
u64 range_start, u64 range_end)
449455
{
450456
struct msm_gem_object *msm_obj = to_msm_bo(obj);
451457
u64 local;
452458
int ret;
453459

454460
mutex_lock(&msm_obj->lock);
455461

456-
ret = msm_gem_get_iova_locked(obj, aspace, &local);
462+
ret = msm_gem_get_iova_locked(obj, aspace, &local,
463+
range_start, range_end);
457464

458465
if (!ret)
459466
ret = msm_gem_pin_iova(obj, aspace);
@@ -465,6 +472,13 @@ int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
465472
return ret;
466473
}
467474

475+
/* get iova and pin it. Should have a matching put */
476+
int msm_gem_get_and_pin_iova(struct drm_gem_object *obj,
477+
struct msm_gem_address_space *aspace, uint64_t *iova)
478+
{
479+
return msm_gem_get_and_pin_iova_range(obj, aspace, iova, 0, U64_MAX);
480+
}
481+
468482
/*
469483
* Get an iova but don't pin it. Doesn't need a put because iovas are currently
470484
* valid for the life of the object
@@ -476,7 +490,7 @@ int msm_gem_get_iova(struct drm_gem_object *obj,
476490
int ret;
477491

478492
mutex_lock(&msm_obj->lock);
479-
ret = msm_gem_get_iova_locked(obj, aspace, iova);
493+
ret = msm_gem_get_iova_locked(obj, aspace, iova, 0, U64_MAX);
480494
mutex_unlock(&msm_obj->lock);
481495

482496
return ret;

drivers/gpu/drm/msm/msm_gem_vma.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,17 @@ void msm_gem_close_vma(struct msm_gem_address_space *aspace,
103103

104104
/* Initialize a new vma and allocate an iova for it */
105105
int msm_gem_init_vma(struct msm_gem_address_space *aspace,
106-
struct msm_gem_vma *vma, int npages)
106+
struct msm_gem_vma *vma, int npages,
107+
u64 range_start, u64 range_end)
107108
{
108109
int ret;
109110

110111
if (WARN_ON(vma->iova))
111112
return -EBUSY;
112113

113114
spin_lock(&aspace->lock);
114-
ret = drm_mm_insert_node(&aspace->mm, &vma->node, npages);
115+
ret = drm_mm_insert_node_in_range(&aspace->mm, &vma->node, npages, 0,
116+
0, range_start, range_end, 0);
115117
spin_unlock(&aspace->lock);
116118

117119
if (ret)

0 commit comments

Comments
 (0)