Skip to content

Commit d945cc8

Browse files
committed
drm/xe/pm: Temporarily disable D3Cold on BMG
Currently, many instability cases related to D3Cold -> D0 transition on BMG are under investigation. Among them some bad cases where the device is lost after 1 to 3 transitions from D3Cold to D0 on the runtime pm, with pcieport upstream bridge port link retrain failure. In other cases, it works fine, but with some sudden random memory corruptions after D3cold, that could be 0xffff missed ack on GT forcewake or GuC reload related failures. In some other cases though, D3Cold -> D0 works pretty reliably. It looks like it is a combination of GPU cards and Host boards at this point. So, there is no possible/available quirk at this time. This patch disables the D3Cold by default on BMG by reducing the vram_d3cold_threshold to 0. Users and developers who wants to enable it are still able to via $ echo 300 > /sys/bus/pci/devices/<addr>/vram_d3cold_threshold Fixes: 3adcf97 ("drm/xe/bmg: Drop force_probe requirement") Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4037 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4395 Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4396 Cc: Karthik Poosa <karthik.poosa@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250308005636.1475420-1-rodrigo.vivi@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 8aa8c2d commit d945cc8

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

drivers/gpu/drm/xe/xe_pm.c

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,15 @@ int xe_pm_init_early(struct xe_device *xe)
277277
}
278278
ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
279279

280+
static u32 vram_threshold_value(struct xe_device *xe)
281+
{
282+
/* FIXME: D3Cold temporarily disabled by default on BMG */
283+
if (xe->info.platform == XE_BATTLEMAGE)
284+
return 0;
285+
286+
return DEFAULT_VRAM_THRESHOLD;
287+
}
288+
280289
/**
281290
* xe_pm_init - Initialize Xe Power Management
282291
* @xe: xe device instance
@@ -287,6 +296,7 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
287296
*/
288297
int xe_pm_init(struct xe_device *xe)
289298
{
299+
u32 vram_threshold;
290300
int err;
291301

292302
/* For now suspend/resume is only allowed with GuC */
@@ -300,7 +310,8 @@ int xe_pm_init(struct xe_device *xe)
300310
if (err)
301311
return err;
302312

303-
err = xe_pm_set_vram_threshold(xe, DEFAULT_VRAM_THRESHOLD);
313+
vram_threshold = vram_threshold_value(xe);
314+
err = xe_pm_set_vram_threshold(xe, vram_threshold);
304315
if (err)
305316
return err;
306317
}

0 commit comments

Comments
 (0)