Skip to content

Commit d9c26d4

Browse files
captain5050acmel
authored andcommitted
perf scripting-engines: Move static to local variable, remove 16384 from .bss
Avoid 16,384 bytes in .bss by stack allocating two bitmaps. Signed-off-by: Ian Rogers <irogers@google.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: K Prateek Nayak <kprateek.nayak@amd.com> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Ross Zwisler <zwisler@chromium.org> Cc: Sean Christopherson <seanjc@google.com> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> Cc: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: Yang Jihong <yangjihong1@huawei.com> Link: https://lore.kernel.org/r/20230526183401.2326121-14-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 370ce16 commit d9c26d4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

tools/perf/util/scripting-engines/trace-event-perl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,6 @@ INTERP my_perl;
6767
#define TRACE_EVENT_TYPE_MAX \
6868
((1 << (sizeof(unsigned short) * 8)) - 1)
6969

70-
static DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX);
71-
7270
extern struct scripting_context *scripting_context;
7371

7472
static char *cur_field_name;
@@ -353,7 +351,9 @@ static void perl_process_tracepoint(struct perf_sample *sample,
353351
void *data = sample->raw_data;
354352
unsigned long long nsecs = sample->time;
355353
const char *comm = thread__comm_str(thread);
354+
DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX);
356355

356+
bitmap_zero(events_defined, TRACE_EVENT_TYPE_MAX);
357357
dSP;
358358

359359
if (evsel->core.attr.type != PERF_TYPE_TRACEPOINT)

tools/perf/util/scripting-engines/trace-event-python.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ PyMODINIT_FUNC PyInit_perf_trace_context(void);
9393
#define TRACE_EVENT_TYPE_MAX \
9494
((1 << (sizeof(unsigned short) * 8)) - 1)
9595

96-
static DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX);
97-
9896
#define N_COMMON_FIELDS 7
9997

10098
static char *cur_field_name;
@@ -934,6 +932,9 @@ static void python_process_tracepoint(struct perf_sample *sample,
934932
unsigned long long nsecs = sample->time;
935933
const char *comm = thread__comm_str(al->thread);
936934
const char *default_handler_name = "trace_unhandled";
935+
DECLARE_BITMAP(events_defined, TRACE_EVENT_TYPE_MAX);
936+
937+
bitmap_zero(events_defined, TRACE_EVENT_TYPE_MAX);
937938

938939
if (!event) {
939940
snprintf(handler_name, sizeof(handler_name),

0 commit comments

Comments
 (0)