Skip to content

Commit dac81a9

Browse files
committed
drm/xe: Add engine name to the engine reset and cat-err log
Add engine name to the engine reset and cat error log which should be useful while debugging. v2: Add logical mask and engine class(Matt) Use xe_gt_{info|dbg} (Michal) Cc: Matthew Brost <matthew.brost@intel.com> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240528101445.27688-1-nirmoy.das@intel.com Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
1 parent a17aceb commit dac81a9

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/gpu/drm/xe/xe_guc_submit.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,6 +1681,7 @@ int xe_guc_deregister_done_handler(struct xe_guc *guc, u32 *msg, u32 len)
16811681

16821682
int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
16831683
{
1684+
struct xe_gt *gt = guc_to_gt(guc);
16841685
struct xe_device *xe = guc_to_xe(guc);
16851686
struct xe_exec_queue *q;
16861687
u32 guc_id = msg[0];
@@ -1694,7 +1695,8 @@ int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
16941695
if (unlikely(!q))
16951696
return -EPROTO;
16961697

1697-
drm_info(&xe->drm, "Engine reset: guc_id=%d", guc_id);
1698+
xe_gt_info(gt, "Engine reset: engine_class=%s, logical_mask: 0x%x, guc_id=%d",
1699+
xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id);
16981700

16991701
/* FIXME: Do error capture, most likely async */
17001702

@@ -1716,6 +1718,7 @@ int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
17161718
int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg,
17171719
u32 len)
17181720
{
1721+
struct xe_gt *gt = guc_to_gt(guc);
17191722
struct xe_device *xe = guc_to_xe(guc);
17201723
struct xe_exec_queue *q;
17211724
u32 guc_id = msg[0];
@@ -1729,7 +1732,9 @@ int xe_guc_exec_queue_memory_cat_error_handler(struct xe_guc *guc, u32 *msg,
17291732
if (unlikely(!q))
17301733
return -EPROTO;
17311734

1732-
drm_dbg(&xe->drm, "Engine memory cat error: guc_id=%d", guc_id);
1735+
xe_gt_dbg(gt, "Engine memory cat error: engine_class=%s, logical_mask: 0x%x, guc_id=%d",
1736+
xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id);
1737+
17331738
trace_xe_exec_queue_memory_cat_error(q);
17341739

17351740
/* Treat the same as engine reset */

0 commit comments

Comments
 (0)