Skip to content

Commit dcc38bc

Browse files
committed
drm/xe/kunit: Drop xe_wa_test_exit
Remove xe_wa_test_exit() as it could crach the KUnit kernel in case of hitting some asserts in xe_wa_test_init() as test->priv could not be pointing to expected data. | # xe_wa_gt: ASSERTION FAILED at drivers/gpu/drm/xe/tests/xe_wa_test.c:34 | Expected ret == 0, but | ret == -19 (0xffffffffffffffed) |Bus error - the host /dev/shm or /tmp mount likely just ran out of space |Kernel panic - not syncing: Kernel mode signal 7 Note that there is no need to call drm_kunit_helper_free_device() since our fake device allocated by drm_kunit_helper_alloc_device() will be cleaned up automatically. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://lore.kernel.org/r/20250829171922.572-7-michal.wajdeczko@intel.com
1 parent a9c8517 commit dcc38bc

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/gpu/drm/xe/tests/xe_wa_test.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,6 @@ static int xe_wa_test_init(struct kunit *test)
4343
return 0;
4444
}
4545

46-
static void xe_wa_test_exit(struct kunit *test)
47-
{
48-
struct xe_device *xe = test->priv;
49-
50-
drm_kunit_helper_free_device(test, xe->drm.dev);
51-
}
52-
5346
static void xe_wa_gt(struct kunit *test)
5447
{
5548
struct xe_device *xe = test->priv;
@@ -74,7 +67,6 @@ static struct kunit_case xe_wa_tests[] = {
7467
static struct kunit_suite xe_rtp_test_suite = {
7568
.name = "xe_wa",
7669
.init = xe_wa_test_init,
77-
.exit = xe_wa_test_exit,
7870
.test_cases = xe_wa_tests,
7971
};
8072

0 commit comments

Comments
 (0)