s390/qeth: Convert sysfs sprintf to sysfs_emit

Thorsten Winkler · kuba-moo · commit dde8769b1211 · 2023-02-10T19:49:53.000-08:00
Following the advice of the Documentation/filesystems/sysfs.rst.
All sysfs related show()-functions should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

Reported-by: Jules Irenge &lt;jbi.octave@gmail.com&gt;
Reported-by: Joe Perches &lt;joe@perches.com&gt;
Reviewed-by: Alexandra Winter &lt;wintera@linux.ibm.com&gt;
Signed-off-by: Thorsten Winkler &lt;twinkler@linux.ibm.com&gt;
Signed-off-by: Alexandra Winter &lt;wintera@linux.ibm.com&gt;
Reviewed-by: Simon Horman &lt;simon.horman@corigine.com&gt;
Signed-off-by: Jakub Kicinski &lt;kuba@kernel.org&gt;
diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c
@@ -23,15 +23,15 @@ static ssize_t qeth_dev_state_show(struct device *dev,
 
 	switch (card->state) {
 	case CARD_STATE_DOWN:
-		return sprintf(buf, "DOWN\n");
+		return sysfs_emit(buf, "DOWN\n");
 	case CARD_STATE_SOFTSETUP:
 		if (card->dev->flags & IFF_UP)
-			return sprintf(buf, "UP (LAN %s)\n",
-				       netif_carrier_ok(card->dev) ? "ONLINE" :
-								     "OFFLINE");
-		return sprintf(buf, "SOFTSETUP\n");
+			return sysfs_emit(buf, "UP (LAN %s)\n",
+					  netif_carrier_ok(card->dev) ?
+					  "ONLINE" : "OFFLINE");
+		return sysfs_emit(buf, "SOFTSETUP\n");
 	default:
-		return sprintf(buf, "UNKNOWN\n");
+		return sysfs_emit(buf, "UNKNOWN\n");
 	}
 }
 
@@ -42,7 +42,7 @@ static ssize_t qeth_dev_chpid_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%02X\n", card->info.chpid);
+	return sysfs_emit(buf, "%02X\n", card->info.chpid);
 }
 
 static DEVICE_ATTR(chpid, 0444, qeth_dev_chpid_show, NULL);
@@ -52,7 +52,7 @@ static ssize_t qeth_dev_if_name_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%s\n", netdev_name(card->dev));
+	return sysfs_emit(buf, "%s\n", netdev_name(card->dev));
 }
 
 static DEVICE_ATTR(if_name, 0444, qeth_dev_if_name_show, NULL);
@@ -62,7 +62,7 @@ static ssize_t qeth_dev_card_type_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%s\n", qeth_get_cardname_short(card));
+	return sysfs_emit(buf, "%s\n", qeth_get_cardname_short(card));
 }
 
 static DEVICE_ATTR(card_type, 0444, qeth_dev_card_type_show, NULL);
@@ -86,7 +86,7 @@ static ssize_t qeth_dev_inbuf_size_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%s\n", qeth_get_bufsize_str(card));
+	return sysfs_emit(buf, "%s\n", qeth_get_bufsize_str(card));
 }
 
 static DEVICE_ATTR(inbuf_size, 0444, qeth_dev_inbuf_size_show, NULL);
@@ -96,7 +96,7 @@ static ssize_t qeth_dev_portno_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->dev->dev_port);
+	return sysfs_emit(buf, "%i\n", card->dev->dev_port);
 }
 
 static ssize_t qeth_dev_portno_store(struct device *dev,
@@ -134,7 +134,7 @@ static DEVICE_ATTR(portno, 0644, qeth_dev_portno_show, qeth_dev_portno_store);
 static ssize_t qeth_dev_portname_show(struct device *dev,
 				struct device_attribute *attr, char *buf)
 {
-	return sprintf(buf, "no portname required\n");
+	return sysfs_emit(buf, "no portname required\n");
 }
 
 static ssize_t qeth_dev_portname_store(struct device *dev,
@@ -157,18 +157,18 @@ static ssize_t qeth_dev_prioqing_show(struct device *dev,
 
 	switch (card->qdio.do_prio_queueing) {
 	case QETH_PRIO_Q_ING_PREC:
-		return sprintf(buf, "%s\n", "by precedence");
+		return sysfs_emit(buf, "%s\n", "by precedence");
 	case QETH_PRIO_Q_ING_TOS:
-		return sprintf(buf, "%s\n", "by type of service");
+		return sysfs_emit(buf, "%s\n", "by type of service");
 	case QETH_PRIO_Q_ING_SKB:
-		return sprintf(buf, "%s\n", "by skb-priority");
+		return sysfs_emit(buf, "%s\n", "by skb-priority");
 	case QETH_PRIO_Q_ING_VLAN:
-		return sprintf(buf, "%s\n", "by VLAN headers");
+		return sysfs_emit(buf, "%s\n", "by VLAN headers");
 	case QETH_PRIO_Q_ING_FIXED:
-		return sprintf(buf, "always queue %i\n",
+		return sysfs_emit(buf, "always queue %i\n",
 			       card->qdio.default_out_queue);
 	default:
-		return sprintf(buf, "disabled\n");
+		return sysfs_emit(buf, "disabled\n");
 	}
 }
 
@@ -242,7 +242,7 @@ static ssize_t qeth_dev_bufcnt_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->qdio.in_buf_pool.buf_count);
+	return sysfs_emit(buf, "%i\n", card->qdio.in_buf_pool.buf_count);
 }
 
 static ssize_t qeth_dev_bufcnt_store(struct device *dev,
@@ -298,7 +298,7 @@ static DEVICE_ATTR(recover, 0200, NULL, qeth_dev_recover_store);
 static ssize_t qeth_dev_performance_stats_show(struct device *dev,
 				struct device_attribute *attr, char *buf)
 {
-	return sprintf(buf, "1\n");
+	return sysfs_emit(buf, "1\n");
 }
 
 static ssize_t qeth_dev_performance_stats_store(struct device *dev,
@@ -335,7 +335,7 @@ static ssize_t qeth_dev_layer2_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->options.layer);
+	return sysfs_emit(buf, "%i\n", card->options.layer);
 }
 
 static ssize_t qeth_dev_layer2_store(struct device *dev,
@@ -470,23 +470,25 @@ static ssize_t qeth_dev_switch_attrs_show(struct device *dev,
 	int	rc = 0;
 
 	if (!qeth_card_hw_is_reachable(card))
-		return sprintf(buf, "n/a\n");
+		return sysfs_emit(buf, "n/a\n");
 
 	rc = qeth_query_switch_attributes(card, &sw_info);
 	if (rc)
 		return rc;
 
 	if (!sw_info.capabilities)
-		rc = sprintf(buf, "unknown");
+		rc = sysfs_emit(buf, "unknown");
 
 	if (sw_info.capabilities & QETH_SWITCH_FORW_802_1)
-		rc = sprintf(buf, (sw_info.settings & QETH_SWITCH_FORW_802_1 ?
-							"[802.1]" : "802.1"));
+		rc = sysfs_emit(buf,
+				(sw_info.settings & QETH_SWITCH_FORW_802_1 ?
+				"[802.1]" : "802.1"));
 	if (sw_info.capabilities & QETH_SWITCH_FORW_REFL_RELAY)
-		rc += sprintf(buf + rc,
-			(sw_info.settings & QETH_SWITCH_FORW_REFL_RELAY ?
-							" [rr]" : " rr"));
-	rc += sprintf(buf + rc, "\n");
+		rc += sysfs_emit_at(buf, rc,
+				    (sw_info.settings &
+				    QETH_SWITCH_FORW_REFL_RELAY ?
+				    " [rr]" : " rr"));
+	rc += sysfs_emit_at(buf, rc, "\n");
 
 	return rc;
 }
@@ -573,7 +575,7 @@ static ssize_t qeth_dev_blkt_total_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->info.blkt.time_total);
+	return sysfs_emit(buf, "%i\n", card->info.blkt.time_total);
 }
 
 static ssize_t qeth_dev_blkt_total_store(struct device *dev,
@@ -593,7 +595,7 @@ static ssize_t qeth_dev_blkt_inter_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->info.blkt.inter_packet);
+	return sysfs_emit(buf, "%i\n", card->info.blkt.inter_packet);
 }
 
 static ssize_t qeth_dev_blkt_inter_store(struct device *dev,
@@ -613,7 +615,7 @@ static ssize_t qeth_dev_blkt_inter_jumbo_show(struct device *dev,
 {
 	struct qeth_card *card = dev_get_drvdata(dev);
 
-	return sprintf(buf, "%i\n", card->info.blkt.inter_packet_jumbo);
+	return sysfs_emit(buf, "%i\n", card->info.blkt.inter_packet_jumbo);
 }
 
 static ssize_t qeth_dev_blkt_inter_jumbo_store(struct device *dev,
diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c
@@ -19,7 +19,7 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
 	char *word;
 
 	if (!qeth_bridgeport_allowed(card))
-		return sprintf(buf, "n/a (VNIC characteristics)\n");
+		return sysfs_emit(buf, "n/a (VNIC characteristics)\n");
 
 	mutex_lock(&card->sbp_lock);
 	if (qeth_card_hw_is_reachable(card) &&
@@ -53,7 +53,7 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev,
 			QETH_CARD_TEXT_(card, 2, "SBP%02x:%02x",
 				card->options.sbp.role, state);
 		else
-			rc = sprintf(buf, "%s\n", word);
+			rc = sysfs_emit(buf, "%s\n", word);
 	}
 	mutex_unlock(&card->sbp_lock);
 
@@ -66,7 +66,7 @@ static ssize_t qeth_bridge_port_role_show(struct device *dev,
 	struct qeth_card *card = dev_get_drvdata(dev);
 
 	if (!qeth_bridgeport_allowed(card))
-		return sprintf(buf, "n/a (VNIC characteristics)\n");
+		return sysfs_emit(buf, "n/a (VNIC characteristics)\n");
 
 	return qeth_bridge_port_role_state_show(dev, attr, buf, 0);
 }
@@ -117,7 +117,7 @@ static ssize_t qeth_bridge_port_state_show(struct device *dev,
 	struct qeth_card *card = dev_get_drvdata(dev);
 
 	if (!qeth_bridgeport_allowed(card))
-		return sprintf(buf, "n/a (VNIC characteristics)\n");
+		return sysfs_emit(buf, "n/a (VNIC characteristics)\n");
 
 	return qeth_bridge_port_role_state_show(dev, attr, buf, 1);
 }
@@ -132,11 +132,11 @@ static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev,
 	int enabled;
 
 	if (!qeth_bridgeport_allowed(card))
-		return sprintf(buf, "n/a (VNIC characteristics)\n");
+		return sysfs_emit(buf, "n/a (VNIC characteristics)\n");
 
 	enabled = card->options.sbp.hostnotification;
 
-	return sprintf(buf, "%d\n", enabled);
+	return sysfs_emit(buf, "%d\n", enabled);
 }
 
 static ssize_t qeth_bridgeport_hostnotification_store(struct device *dev,
@@ -180,7 +180,7 @@ static ssize_t qeth_bridgeport_reflect_show(struct device *dev,
 	char *state;
 
 	if (!qeth_bridgeport_allowed(card))
-		return sprintf(buf, "n/a (VNIC characteristics)\n");
+		return sysfs_emit(buf, "n/a (VNIC characteristics)\n");
 
 	if (card->options.sbp.reflect_promisc) {
 		if (card->options.sbp.reflect_promisc_primary)
@@ -190,7 +190,7 @@ static ssize_t qeth_bridgeport_reflect_show(struct device *dev,
 	} else
 		state = "none";
 
-	return sprintf(buf, "%s\n", state);
+	return sysfs_emit(buf, "%s\n", state);
 }
 
 static ssize_t qeth_bridgeport_reflect_store(struct device *dev,
@@ -280,10 +280,10 @@ static ssize_t qeth_vnicc_timeout_show(struct device *dev,
 
 	rc = qeth_l2_vnicc_get_timeout(card, &timeout);
 	if (rc == -EBUSY)
-		return sprintf(buf, "n/a (BridgePort)\n");
+		return sysfs_emit(buf, "n/a (BridgePort)\n");
 	if (rc == -EOPNOTSUPP)
-		return sprintf(buf, "n/a\n");
-	return rc ? rc : sprintf(buf, "%d\n", timeout);
+		return sysfs_emit(buf, "n/a\n");
+	return rc ? rc : sysfs_emit(buf, "%d\n", timeout);
 }
 
 /* change timeout setting */
@@ -318,10 +318,10 @@ static ssize_t qeth_vnicc_char_show(struct device *dev,
 	rc = qeth_l2_vnicc_get_state(card, vnicc, &state);
 
 	if (rc == -EBUSY)
-		return sprintf(buf, "n/a (BridgePort)\n");
+		return sysfs_emit(buf, "n/a (BridgePort)\n");
 	if (rc == -EOPNOTSUPP)
-		return sprintf(buf, "n/a\n");
-	return rc ? rc : sprintf(buf, "%d\n", state);
+		return sysfs_emit(buf, "n/a\n");
+	return rc ? rc : sysfs_emit(buf, "%d\n", state);
 }
 
 /* change setting of characteristic */
diff --git a/drivers/s390/net/qeth_l3_sys.c b/drivers/s390/net/qeth_l3_sys.c

Original file line number	Diff line number	Diff line change
`@@ -23,15 +23,15 @@ static ssize_t qeth_dev_state_show(struct device *dev,`
`23`	`23`
`24`	`24`	`switch (card->state) {`
`25`	`25`	`case CARD_STATE_DOWN:`
`26`		`- return sprintf(buf, "DOWN\n");`
	`26`	`+ return sysfs_emit(buf, "DOWN\n");`
`27`	`27`	`case CARD_STATE_SOFTSETUP:`
`28`	`28`	`if (card->dev->flags & IFF_UP)`
`29`		`- return sprintf(buf, "UP (LAN %s)\n",`
`30`		`- netif_carrier_ok(card->dev) ? "ONLINE" :`
`31`		`- "OFFLINE");`
`32`		`- return sprintf(buf, "SOFTSETUP\n");`
	`29`	`+ return sysfs_emit(buf, "UP (LAN %s)\n",`
	`30`	`+ netif_carrier_ok(card->dev) ?`
	`31`	`+ "ONLINE" : "OFFLINE");`
	`32`	`+ return sysfs_emit(buf, "SOFTSETUP\n");`
`33`	`33`	`default:`
`34`		`- return sprintf(buf, "UNKNOWN\n");`
	`34`	`+ return sysfs_emit(buf, "UNKNOWN\n");`
`35`	`35`	`}`
`36`	`36`	`}`
`37`	`37`
`@@ -42,7 +42,7 @@ static ssize_t qeth_dev_chpid_show(struct device *dev,`
`42`	`42`	`{`
`43`	`43`	`struct qeth_card *card = dev_get_drvdata(dev);`
`44`	`44`
`45`		`- return sprintf(buf, "%02X\n", card->info.chpid);`
	`45`	`+ return sysfs_emit(buf, "%02X\n", card->info.chpid);`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`static DEVICE_ATTR(chpid, 0444, qeth_dev_chpid_show, NULL);`
`@@ -52,7 +52,7 @@ static ssize_t qeth_dev_if_name_show(struct device *dev,`
`52`	`52`	`{`
`53`	`53`	`struct qeth_card *card = dev_get_drvdata(dev);`
`54`	`54`
`55`		`- return sprintf(buf, "%s\n", netdev_name(card->dev));`
	`55`	`+ return sysfs_emit(buf, "%s\n", netdev_name(card->dev));`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`static DEVICE_ATTR(if_name, 0444, qeth_dev_if_name_show, NULL);`
`@@ -62,7 +62,7 @@ static ssize_t qeth_dev_card_type_show(struct device *dev,`
`62`	`62`	`{`
`63`	`63`	`struct qeth_card *card = dev_get_drvdata(dev);`
`64`	`64`
`65`		`- return sprintf(buf, "%s\n", qeth_get_cardname_short(card));`
	`65`	`+ return sysfs_emit(buf, "%s\n", qeth_get_cardname_short(card));`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`static DEVICE_ATTR(card_type, 0444, qeth_dev_card_type_show, NULL);`
`@@ -86,7 +86,7 @@ static ssize_t qeth_dev_inbuf_size_show(struct device *dev,`
`86`	`86`	`{`
`87`	`87`	`struct qeth_card *card = dev_get_drvdata(dev);`
`88`	`88`
`89`		`- return sprintf(buf, "%s\n", qeth_get_bufsize_str(card));`
	`89`	`+ return sysfs_emit(buf, "%s\n", qeth_get_bufsize_str(card));`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`static DEVICE_ATTR(inbuf_size, 0444, qeth_dev_inbuf_size_show, NULL);`
`@@ -96,7 +96,7 @@ static ssize_t qeth_dev_portno_show(struct device *dev,`
`96`	`96`	`{`
`97`	`97`	`struct qeth_card *card = dev_get_drvdata(dev);`
`98`	`98`
`99`		`- return sprintf(buf, "%i\n", card->dev->dev_port);`
	`99`	`+ return sysfs_emit(buf, "%i\n", card->dev->dev_port);`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`static ssize_t qeth_dev_portno_store(struct device *dev,`
`@@ -134,7 +134,7 @@ static DEVICE_ATTR(portno, 0644, qeth_dev_portno_show, qeth_dev_portno_store);`
`134`	`134`	`static ssize_t qeth_dev_portname_show(struct device *dev,`
`135`	`135`	`struct device_attribute attr, char buf)`
`136`	`136`	`{`
`137`		`- return sprintf(buf, "no portname required\n");`
	`137`	`+ return sysfs_emit(buf, "no portname required\n");`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`static ssize_t qeth_dev_portname_store(struct device *dev,`
`@@ -157,18 +157,18 @@ static ssize_t qeth_dev_prioqing_show(struct device *dev,`
`157`	`157`
`158`	`158`	`switch (card->qdio.do_prio_queueing) {`
`159`	`159`	`case QETH_PRIO_Q_ING_PREC:`
`160`		`- return sprintf(buf, "%s\n", "by precedence");`
	`160`	`+ return sysfs_emit(buf, "%s\n", "by precedence");`
`161`	`161`	`case QETH_PRIO_Q_ING_TOS:`
`162`		`- return sprintf(buf, "%s\n", "by type of service");`
	`162`	`+ return sysfs_emit(buf, "%s\n", "by type of service");`
`163`	`163`	`case QETH_PRIO_Q_ING_SKB:`
`164`		`- return sprintf(buf, "%s\n", "by skb-priority");`
	`164`	`+ return sysfs_emit(buf, "%s\n", "by skb-priority");`
`165`	`165`	`case QETH_PRIO_Q_ING_VLAN:`
`166`		`- return sprintf(buf, "%s\n", "by VLAN headers");`
	`166`	`+ return sysfs_emit(buf, "%s\n", "by VLAN headers");`
`167`	`167`	`case QETH_PRIO_Q_ING_FIXED:`
`168`		`- return sprintf(buf, "always queue %i\n",`
	`168`	`+ return sysfs_emit(buf, "always queue %i\n",`
`169`	`169`	`card->qdio.default_out_queue);`
`170`	`170`	`default:`
`171`		`- return sprintf(buf, "disabled\n");`
	`171`	`+ return sysfs_emit(buf, "disabled\n");`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`
`@@ -242,7 +242,7 @@ static ssize_t qeth_dev_bufcnt_show(struct device *dev,`
`242`	`242`	`{`
`243`	`243`	`struct qeth_card *card = dev_get_drvdata(dev);`
`244`	`244`
`245`		`- return sprintf(buf, "%i\n", card->qdio.in_buf_pool.buf_count);`
	`245`	`+ return sysfs_emit(buf, "%i\n", card->qdio.in_buf_pool.buf_count);`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`static ssize_t qeth_dev_bufcnt_store(struct device *dev,`
`@@ -298,7 +298,7 @@ static DEVICE_ATTR(recover, 0200, NULL, qeth_dev_recover_store);`
`298`	`298`	`static ssize_t qeth_dev_performance_stats_show(struct device *dev,`
`299`	`299`	`struct device_attribute attr, char buf)`
`300`	`300`	`{`
`301`		`- return sprintf(buf, "1\n");`
	`301`	`+ return sysfs_emit(buf, "1\n");`
`302`	`302`	`}`
`303`	`303`
`304`	`304`	`static ssize_t qeth_dev_performance_stats_store(struct device *dev,`
`@@ -335,7 +335,7 @@ static ssize_t qeth_dev_layer2_show(struct device *dev,`
`335`	`335`	`{`
`336`	`336`	`struct qeth_card *card = dev_get_drvdata(dev);`
`337`	`337`
`338`		`- return sprintf(buf, "%i\n", card->options.layer);`
	`338`	`+ return sysfs_emit(buf, "%i\n", card->options.layer);`
`339`	`339`	`}`
`340`	`340`
`341`	`341`	`static ssize_t qeth_dev_layer2_store(struct device *dev,`
`@@ -470,23 +470,25 @@ static ssize_t qeth_dev_switch_attrs_show(struct device *dev,`
`470`	`470`	`int rc = 0;`
`471`	`471`
`472`	`472`	`if (!qeth_card_hw_is_reachable(card))`
`473`		`- return sprintf(buf, "n/a\n");`
	`473`	`+ return sysfs_emit(buf, "n/a\n");`
`474`	`474`
`475`	`475`	`rc = qeth_query_switch_attributes(card, &sw_info);`
`476`	`476`	`if (rc)`
`477`	`477`	`return rc;`
`478`	`478`
`479`	`479`	`if (!sw_info.capabilities)`
`480`		`- rc = sprintf(buf, "unknown");`
	`480`	`+ rc = sysfs_emit(buf, "unknown");`
`481`	`481`
`482`	`482`	`if (sw_info.capabilities & QETH_SWITCH_FORW_802_1)`
`483`		`- rc = sprintf(buf, (sw_info.settings & QETH_SWITCH_FORW_802_1 ?`
`484`		`- "[802.1]" : "802.1"));`
	`483`	`+ rc = sysfs_emit(buf,`
	`484`	`+ (sw_info.settings & QETH_SWITCH_FORW_802_1 ?`
	`485`	`+ "[802.1]" : "802.1"));`
`485`	`486`	`if (sw_info.capabilities & QETH_SWITCH_FORW_REFL_RELAY)`
`486`		`- rc += sprintf(buf + rc,`
`487`		`- (sw_info.settings & QETH_SWITCH_FORW_REFL_RELAY ?`
`488`		`- " [rr]" : " rr"));`
`489`		`- rc += sprintf(buf + rc, "\n");`
	`487`	`+ rc += sysfs_emit_at(buf, rc,`
	`488`	`+ (sw_info.settings &`
	`489`	`+ QETH_SWITCH_FORW_REFL_RELAY ?`
	`490`	`+ " [rr]" : " rr"));`
	`491`	`+ rc += sysfs_emit_at(buf, rc, "\n");`
`490`	`492`
`491`	`493`	`return rc;`
`492`	`494`	`}`
`@@ -573,7 +575,7 @@ static ssize_t qeth_dev_blkt_total_show(struct device *dev,`
`573`	`575`	`{`
`574`	`576`	`struct qeth_card *card = dev_get_drvdata(dev);`
`575`	`577`
`576`		`- return sprintf(buf, "%i\n", card->info.blkt.time_total);`
	`578`	`+ return sysfs_emit(buf, "%i\n", card->info.blkt.time_total);`
`577`	`579`	`}`
`578`	`580`
`579`	`581`	`static ssize_t qeth_dev_blkt_total_store(struct device *dev,`
`@@ -593,7 +595,7 @@ static ssize_t qeth_dev_blkt_inter_show(struct device *dev,`
`593`	`595`	`{`
`594`	`596`	`struct qeth_card *card = dev_get_drvdata(dev);`
`595`	`597`
`596`		`- return sprintf(buf, "%i\n", card->info.blkt.inter_packet);`
	`598`	`+ return sysfs_emit(buf, "%i\n", card->info.blkt.inter_packet);`
`597`	`599`	`}`
`598`	`600`
`599`	`601`	`static ssize_t qeth_dev_blkt_inter_store(struct device *dev,`
`@@ -613,7 +615,7 @@ static ssize_t qeth_dev_blkt_inter_jumbo_show(struct device *dev,`
`613`	`615`	`{`
`614`	`616`	`struct qeth_card *card = dev_get_drvdata(dev);`
`615`	`617`
`616`		`- return sprintf(buf, "%i\n", card->info.blkt.inter_packet_jumbo);`
	`618`	`+ return sysfs_emit(buf, "%i\n", card->info.blkt.inter_packet_jumbo);`
`617`	`619`	`}`
`618`	`620`
`619`	`621`	`static ssize_t qeth_dev_blkt_inter_jumbo_store(struct device *dev,`