Skip to content

Commit de84ffc

Browse files
Sam Bobroffmpe
authored andcommitted
powerpc/eeh: differentiate duplicate detection message
Currently when an EEH error is detected, the system log receives the same (or almost the same) message twice: EEH: PHB#0 failure detected, location: N/A EEH: PHB#0 failure detected, location: N/A or EEH: eeh_dev_check_failure: Frozen PHB#0-PE#0 detected EEH: Frozen PHB#0-PE#0 detected This looks like a bug, but in fact the messages are from different functions and mean slightly different things. So keep both but change one of the messages slightly, so that it's clear they are different: EEH: PHB#0 failure detected, location: N/A EEH: Recovering PHB#0, location: N/A or EEH: eeh_dev_check_failure: Frozen PHB#0-PE#0 detected EEH: Recovering PHB#0-PE#0 Signed-off-by: Sam Bobroff <sbobroff@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/43817cb6e6631b0828b9a6e266f60d1f8ca8eb22.1571288375.git.sbobroff@linux.ibm.com
1 parent b948aaa commit de84ffc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

arch/powerpc/kernel/eeh_driver.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -881,12 +881,12 @@ void eeh_handle_normal_event(struct eeh_pe *pe)
881881

882882
/* Log the event */
883883
if (pe->type & EEH_PE_PHB) {
884-
pr_err("EEH: PHB#%x failure detected, location: %s\n",
884+
pr_err("EEH: Recovering PHB#%x, location: %s\n",
885885
pe->phb->global_number, eeh_pe_loc_get(pe));
886886
} else {
887887
struct eeh_pe *phb_pe = eeh_phb_pe_get(pe->phb);
888888

889-
pr_err("EEH: Frozen PHB#%x-PE#%x detected\n",
889+
pr_err("EEH: Recovering PHB#%x-PE#%x\n",
890890
pe->phb->global_number, pe->addr);
891891
pr_err("EEH: PE location: %s, PHB location: %s\n",
892892
eeh_pe_loc_get(pe), eeh_pe_loc_get(phb_pe));

0 commit comments

Comments
 (0)