bonding: bond_get_size() returns wrong size

Dan Carpenter · davem330 · commit e139862eeec9 · 2013-11-02T02:08:54.000-04:00
There is an extra semi-colon so bond_get_size() doesn't return the correct value. Fixes: ec76aa4 ('bonding: add Netlink support active_slave option') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Veaceslav Falico <vfalico@redhat.com> Reviewed-by: Jiri Pirko <jiri@resnulli.us> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
@@ -82,8 +82,8 @@ static int bond_newlink(struct net *src_net, struct net_device *bond_dev,
 
 static size_t bond_get_size(const struct net_device *bond_dev)
 {
-	return nla_total_size(sizeof(u8));	/* IFLA_BOND_MODE */
-		+ nla_total_size(sizeof(u32));	/* IFLA_BOND_ACTIVE_SLAVE */
+	return nla_total_size(sizeof(u8)) +	/* IFLA_BOND_MODE */
+		nla_total_size(sizeof(u32));	/* IFLA_BOND_ACTIVE_SLAVE */
 }
 
 static int bond_fill_info(struct sk_buff *skb,

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,8 @@ static int bond_newlink(struct net src_net, struct net_device bond_dev,`
`82`	`82`
`83`	`83`	`static size_t bond_get_size(const struct net_device *bond_dev)`
`84`	`84`	`{`
`85`		`- return nla_total_size(sizeof(u8)); /* IFLA_BOND_MODE */`
`86`		`- + nla_total_size(sizeof(u32)); /* IFLA_BOND_ACTIVE_SLAVE */`
	`85`	`+ return nla_total_size(sizeof(u8)) + /* IFLA_BOND_MODE */`
	`86`	`+ nla_total_size(sizeof(u32)); /* IFLA_BOND_ACTIVE_SLAVE */`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`static int bond_fill_info(struct sk_buff *skb,`