Skip to content

Commit e16edc9

Browse files
stefano-garzarelladavem330
authored andcommitted
vsock/vmci: log once the failed queue pair allocation
VMCI feature is not supported in conjunction with the vSphere Fault Tolerance (FT) feature. VMware Tools can repeatedly try to create a vsock connection. If FT is enabled the kernel logs is flooded with the following messages: qp_alloc_hypercall result = -20 Could not attach to queue pair with -20 "qp_alloc_hypercall result = -20" was hidden by commit e8266c4 ("VMCI: Stop log spew when qp allocation isn't possible"), but "Could not attach to queue pair with -20" is still there flooding the log. Since the error message can be useful in some cases, print it only once. Fixes: d021c34 ("VSOCK: Introduce VM Sockets") Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> Reviewed-by: Jorgen Hansen <jhansen@vmware.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 88a5af9 commit e16edc9

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

net/vmw_vsock/vmci_transport.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -568,8 +568,7 @@ vmci_transport_queue_pair_alloc(struct vmci_qp **qpair,
568568
peer, flags, VMCI_NO_PRIVILEGE_FLAGS);
569569
out:
570570
if (err < 0) {
571-
pr_err("Could not attach to queue pair with %d\n",
572-
err);
571+
pr_err_once("Could not attach to queue pair with %d\n", err);
573572
err = vmci_transport_error_to_vsock_error(err);
574573
}
575574

0 commit comments

Comments
 (0)