Skip to content

Commit e17f487

Browse files
Bartosz Golaszewskigregkh
authored andcommitted
misc: microchip: pci1xxxx: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Link: https://lore.kernel.org/r/20250408-gpiochip-set-rv-misc-v1-1-eb6345aea5cd@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 92d2261 commit e17f487

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,15 +114,16 @@ static int pci1xxxx_gpio_direction_output(struct gpio_chip *gpio,
114114
return 0;
115115
}
116116

117-
static void pci1xxxx_gpio_set(struct gpio_chip *gpio,
118-
unsigned int nr, int val)
117+
static int pci1xxxx_gpio_set(struct gpio_chip *gpio, unsigned int nr, int val)
119118
{
120119
struct pci1xxxx_gpio *priv = gpiochip_get_data(gpio);
121120
unsigned long flags;
122121

123122
spin_lock_irqsave(&priv->lock, flags);
124123
pci1xxx_assign_bit(priv->reg_base, OUT_OFFSET(nr), (nr % 32), val);
125124
spin_unlock_irqrestore(&priv->lock, flags);
125+
126+
return 0;
126127
}
127128

128129
static int pci1xxxx_gpio_set_config(struct gpio_chip *gpio, unsigned int offset,
@@ -345,7 +346,7 @@ static int pci1xxxx_gpio_setup(struct pci1xxxx_gpio *priv, int irq)
345346
gchip->direction_output = pci1xxxx_gpio_direction_output;
346347
gchip->get_direction = pci1xxxx_gpio_get_direction;
347348
gchip->get = pci1xxxx_gpio_get;
348-
gchip->set = pci1xxxx_gpio_set;
349+
gchip->set_rv = pci1xxxx_gpio_set;
349350
gchip->set_config = pci1xxxx_gpio_set_config;
350351
gchip->dbg_show = NULL;
351352
gchip->base = -1;

0 commit comments

Comments
 (0)