Skip to content

Commit e52fe10

Browse files
committed
EDAC/i10nm: fix refcount leak in pci_get_dev_wrapper()
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2165650 Tested: tested with the EMR machine we have in the lab commit 9c89215 Author: Yang Yingliang <yangyingliang@huawei.com> Date: Mon Nov 28 14:55:12 2022 +0800 EDAC/i10nm: fix refcount leak in pci_get_dev_wrapper() As the comment of pci_get_domain_bus_and_slot() says, it returns a PCI device with refcount incremented, so it doesn't need to call an extra pci_dev_get() in pci_get_dev_wrapper(), and the PCI device needs to be put in the error path. Fixes: d4dc89d ("EDAC, i10nm: Add a driver for Intel 10nm server processors") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Link: https://lore.kernel.org/r/20221128065512.3572550-1-yangyingliang@huawei.com Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
1 parent 73267f7 commit e52fe10

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/edac/i10nm_base.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,11 +302,10 @@ static struct pci_dev *pci_get_dev_wrapper(int dom, unsigned int bus,
302302
if (unlikely(pci_enable_device(pdev) < 0)) {
303303
edac_dbg(2, "Failed to enable device %02x:%02x.%x\n",
304304
bus, dev, fun);
305+
pci_dev_put(pdev);
305306
return NULL;
306307
}
307308

308-
pci_dev_get(pdev);
309-
310309
return pdev;
311310
}
312311

0 commit comments

Comments
 (0)