Skip to content

Commit e97ec7f

Browse files
debox1jwrdegoede
authored andcommitted
platform/x86/intel/vsec: Add base address field
Some devices may emulate PCI VSEC capabilities in MMIO. In such cases the BAR is not readable from a config space. Provide a field for drivers to indicate the base address to be used. Signed-off-by: David E. Box <david.e.box@linux.intel.com> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/20231129222132.2331261-9-david.e.box@linux.intel.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent 4edbd11 commit e97ec7f

File tree

3 files changed

+21
-5
lines changed

3 files changed

+21
-5
lines changed

drivers/platform/x86/intel/pmt/class.c

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,11 @@ static struct class intel_pmt_class = {
160160

161161
static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
162162
struct intel_pmt_header *header,
163-
struct device *dev,
163+
struct intel_vsec_device *ivdev,
164164
struct resource *disc_res)
165165
{
166-
struct pci_dev *pci_dev = to_pci_dev(dev->parent);
166+
struct pci_dev *pci_dev = ivdev->pcidev;
167+
struct device *dev = &ivdev->auxdev.dev;
167168
u8 bir;
168169

169170
/*
@@ -215,6 +216,13 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry,
215216

216217
break;
217218
case ACCESS_BARID:
219+
/* Use the provided base address if it exists */
220+
if (ivdev->base_addr) {
221+
entry->base_addr = ivdev->base_addr +
222+
GET_ADDRESS(header->base_offset);
223+
break;
224+
}
225+
218226
/*
219227
* If another BAR was specified then the base offset
220228
* represents the offset within that BAR. SO retrieve the
@@ -319,7 +327,7 @@ int intel_pmt_dev_create(struct intel_pmt_entry *entry, struct intel_pmt_namespa
319327
if (ret)
320328
return ret;
321329

322-
ret = intel_pmt_populate_entry(entry, &header, dev, disc_res);
330+
ret = intel_pmt_populate_entry(entry, &header, intel_vsec_dev, disc_res);
323331
if (ret)
324332
return ret;
325333

drivers/platform/x86/intel/vsec.c

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
154154
struct resource *tmp;
155155
struct device *parent;
156156
unsigned long quirks = info->quirks;
157+
u64 base_addr;
157158
int i;
158159

159160
if (info->parent)
@@ -185,14 +186,18 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
185186
if (quirks & VSEC_QUIRK_TABLE_SHIFT)
186187
header->offset >>= TABLE_OFFSET_SHIFT;
187188

189+
if (info->base_addr)
190+
base_addr = info->base_addr;
191+
else
192+
base_addr = pdev->resource[header->tbir].start;
193+
188194
/*
189195
* The DVSEC/VSEC contains the starting offset and count for a block of
190196
* discovery tables. Create a resource array of these tables to the
191197
* auxiliary device driver.
192198
*/
193199
for (i = 0, tmp = res; i < header->num_entries; i++, tmp++) {
194-
tmp->start = pdev->resource[header->tbir].start +
195-
header->offset + i * (header->entry_size * sizeof(u32));
200+
tmp->start = base_addr + header->offset + i * (header->entry_size * sizeof(u32));
196201
tmp->end = tmp->start + (header->entry_size * sizeof(u32)) - 1;
197202
tmp->flags = IORESOURCE_MEM;
198203

@@ -207,6 +212,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_header *he
207212
intel_vsec_dev->resource = no_free_ptr(res);
208213
intel_vsec_dev->num_resources = header->num_entries;
209214
intel_vsec_dev->quirks = info->quirks;
215+
intel_vsec_dev->base_addr = info->base_addr;
210216

211217
if (header->id == VSEC_ID_SDSI)
212218
intel_vsec_dev->ida = &intel_vsec_sdsi_ida;

drivers/platform/x86/intel/vsec.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ struct intel_vsec_platform_info {
7373
struct intel_vsec_header **headers;
7474
unsigned long caps;
7575
unsigned long quirks;
76+
u64 base_addr;
7677
};
7778

7879
struct intel_vsec_device {
@@ -85,6 +86,7 @@ struct intel_vsec_device {
8586
void *priv_data;
8687
size_t priv_data_size;
8788
unsigned long quirks;
89+
u64 base_addr;
8890
};
8991

9092
int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,

0 commit comments

Comments
 (0)