Skip to content

Commit ec52cd3

Browse files
committed
Merge back int340x thermal driver changes for v5.18.
2 parents 3abea10 + 098c874 commit ec52cd3

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

drivers/thermal/intel/int340x_thermal/acpi_thermal_rel.c

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp,
7272
int i;
7373
int nr_bad_entries = 0;
7474
struct trt *trts;
75-
struct acpi_device *adev;
7675
union acpi_object *p;
7776
struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
7877
struct acpi_buffer element = { 0, NULL };
@@ -112,12 +111,10 @@ int acpi_parse_trt(acpi_handle handle, int *trt_count, struct trt **trtp,
112111
if (!create_dev)
113112
continue;
114113

115-
result = acpi_bus_get_device(trt->source, &adev);
116-
if (result)
114+
if (!acpi_fetch_acpi_dev(trt->source))
117115
pr_warn("Failed to get source ACPI device\n");
118116

119-
result = acpi_bus_get_device(trt->target, &adev);
120-
if (result)
117+
if (!acpi_fetch_acpi_dev(trt->target))
121118
pr_warn("Failed to get target ACPI device\n");
122119
}
123120

@@ -149,7 +146,6 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp,
149146
int i;
150147
int nr_bad_entries = 0;
151148
struct art *arts;
152-
struct acpi_device *adev;
153149
union acpi_object *p;
154150
struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
155151
struct acpi_buffer element = { 0, NULL };
@@ -191,16 +187,11 @@ int acpi_parse_art(acpi_handle handle, int *art_count, struct art **artp,
191187
if (!create_dev)
192188
continue;
193189

194-
if (art->source) {
195-
result = acpi_bus_get_device(art->source, &adev);
196-
if (result)
197-
pr_warn("Failed to get source ACPI device\n");
198-
}
199-
if (art->target) {
200-
result = acpi_bus_get_device(art->target, &adev);
201-
if (result)
202-
pr_warn("Failed to get target ACPI device\n");
203-
}
190+
if (!acpi_fetch_acpi_dev(art->source))
191+
pr_warn("Failed to get source ACPI device\n");
192+
193+
if (!acpi_fetch_acpi_dev(art->target))
194+
pr_warn("Failed to get target ACPI device\n");
204195
}
205196

206197
*artp = arts;

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,11 @@ static void int3400_setup_gddv(struct int3400_thermal_priv *priv)
468468
priv->data_vault = kmemdup(obj->package.elements[0].buffer.pointer,
469469
obj->package.elements[0].buffer.length,
470470
GFP_KERNEL);
471+
if (!priv->data_vault) {
472+
kfree(buffer.pointer);
473+
return;
474+
}
475+
471476
bin_attr_data_vault.private = priv->data_vault;
472477
bin_attr_data_vault.size = obj->package.elements[0].buffer.length;
473478
kfree(buffer.pointer);

0 commit comments

Comments
 (0)