Skip to content

Commit ecd2a77

Browse files
kmaloordavem330
authored andcommitted
selftests: mptcp: support MPTCP_PM_CMD_REMOVE
This change updates the "pm_nl_ctl" testing sample with a "rem" (remove) option to support the newly added netlink interface command MPTCP_PM_CMD_REMOVE to issue a REMOVE_ADDR signal over the chosen MPTCP connection. E.g. ./pm_nl_ctl rem token 823274047 id 23 Acked-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Kishen Maloor <kishen.maloor@intel.com> Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d9a4594 commit ecd2a77

File tree

1 file changed

+52
-0
lines changed

1 file changed

+52
-0
lines changed

tools/testing/selftests/net/mptcp/pm_nl_ctl.c

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ static void syntax(char *argv[])
2828
fprintf(stderr, "%s add|get|set|del|flush|dump|accept [<args>]\n", argv[0]);
2929
fprintf(stderr, "\tadd [flags signal|subflow|backup|fullmesh] [id <nr>] [dev <name>] <ip>\n");
3030
fprintf(stderr, "\tann <local-ip> id <local-id> token <token> [port <local-port>] [dev <name>]\n");
31+
fprintf(stderr, "\trem id <local-id> token <token>\n");
3132
fprintf(stderr, "\tdel <id> [<ip>]\n");
3233
fprintf(stderr, "\tget <id>\n");
3334
fprintf(stderr, "\tset [<ip>] [id <nr>] flags [no]backup|[no]fullmesh [port <nr>]\n");
@@ -172,6 +173,55 @@ static int resolve_mptcp_pm_netlink(int fd)
172173
return genl_parse_getfamily((void *)data);
173174
}
174175

176+
int remove_addr(int fd, int pm_family, int argc, char *argv[])
177+
{
178+
char data[NLMSG_ALIGN(sizeof(struct nlmsghdr)) +
179+
NLMSG_ALIGN(sizeof(struct genlmsghdr)) +
180+
1024];
181+
struct nlmsghdr *nh;
182+
struct rtattr *rta;
183+
u_int32_t token;
184+
u_int8_t id;
185+
int off = 0;
186+
int arg;
187+
188+
memset(data, 0, sizeof(data));
189+
nh = (void *)data;
190+
off = init_genl_req(data, pm_family, MPTCP_PM_CMD_REMOVE,
191+
MPTCP_PM_VER);
192+
193+
if (argc < 6)
194+
syntax(argv);
195+
196+
for (arg = 2; arg < argc; arg++) {
197+
if (!strcmp(argv[arg], "id")) {
198+
if (++arg >= argc)
199+
error(1, 0, " missing id value");
200+
201+
id = atoi(argv[arg]);
202+
rta = (void *)(data + off);
203+
rta->rta_type = MPTCP_PM_ATTR_LOC_ID;
204+
rta->rta_len = RTA_LENGTH(1);
205+
memcpy(RTA_DATA(rta), &id, 1);
206+
off += NLMSG_ALIGN(rta->rta_len);
207+
} else if (!strcmp(argv[arg], "token")) {
208+
if (++arg >= argc)
209+
error(1, 0, " missing token value");
210+
211+
token = atoi(argv[arg]);
212+
rta = (void *)(data + off);
213+
rta->rta_type = MPTCP_PM_ATTR_TOKEN;
214+
rta->rta_len = RTA_LENGTH(4);
215+
memcpy(RTA_DATA(rta), &token, 4);
216+
off += NLMSG_ALIGN(rta->rta_len);
217+
} else
218+
error(1, 0, "unknown keyword %s", argv[arg]);
219+
}
220+
221+
do_nl_req(fd, nh, off, 0);
222+
return 0;
223+
}
224+
175225
int announce_addr(int fd, int pm_family, int argc, char *argv[])
176226
{
177227
char data[NLMSG_ALIGN(sizeof(struct nlmsghdr)) +
@@ -917,6 +967,8 @@ int main(int argc, char *argv[])
917967
return add_addr(fd, pm_family, argc, argv);
918968
else if (!strcmp(argv[1], "ann"))
919969
return announce_addr(fd, pm_family, argc, argv);
970+
else if (!strcmp(argv[1], "rem"))
971+
return remove_addr(fd, pm_family, argc, argv);
920972
else if (!strcmp(argv[1], "del"))
921973
return del_addr(fd, pm_family, argc, argv);
922974
else if (!strcmp(argv[1], "flush"))

0 commit comments

Comments
 (0)