Skip to content

Commit ece70e7

Browse files
qianfengrongBartosz Golaszewski
authored andcommitted
gpio: stp-xway: Simplify using devm_clk_get_enabled()
Use devm_clk_get_enabled() simplify xway_stp_probe(). Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com> Link: https://lore.kernel.org/r/20240820121651.29706-2-rongqianfeng@vivo.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent d25f9ab commit ece70e7

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

drivers/gpio/gpio-stp-xway.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -296,23 +296,17 @@ static int xway_stp_probe(struct platform_device *pdev)
296296
if (!of_property_read_bool(pdev->dev.of_node, "lantiq,rising"))
297297
chip->edge = XWAY_STP_FALLING;
298298

299-
clk = devm_clk_get(&pdev->dev, NULL);
299+
clk = devm_clk_get_enabled(&pdev->dev, NULL);
300300
if (IS_ERR(clk)) {
301301
dev_err(&pdev->dev, "Failed to get clock\n");
302302
return PTR_ERR(clk);
303303
}
304304

305-
ret = clk_prepare_enable(clk);
306-
if (ret)
307-
return ret;
308-
309305
xway_stp_hw_init(chip);
310306

311307
ret = devm_gpiochip_add_data(&pdev->dev, &chip->gc, chip);
312-
if (ret) {
313-
clk_disable_unprepare(clk);
308+
if (ret)
314309
return ret;
315-
}
316310

317311
dev_info(&pdev->dev, "Init done\n");
318312

0 commit comments

Comments
 (0)