Skip to content

Commit f0a6698

Browse files
idoschdavem330
authored andcommitted
mlxsw: spectrum_router: Add proper function documentation
Suppress following warnings when compiling with W=1: drivers/net/ethernet/mellanox/mlxsw//spectrum_router.c:1552: warning: Function parameter or member 'mlxsw_sp' not described in '__mlxsw_sp_ipip_entry_update_tunnel' drivers/net/ethernet/mellanox/mlxsw//spectrum_router.c:1552: warning: Function parameter or member 'ipip_entry' not described in '__mlxsw_sp_ipip_entry_update_tunnel' drivers/net/ethernet/mellanox/mlxsw//spectrum_router.c:1552: warning: Function parameter or member 'extack' not described in '__mlxsw_sp_ipip_entry_update_tunnel' Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reviewed-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5769e39 commit f0a6698

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1535,13 +1535,17 @@ static void mlxsw_sp_nexthop_rif_update(struct mlxsw_sp *mlxsw_sp,
15351535
struct mlxsw_sp_rif *rif);
15361536

15371537
/**
1538-
* Update the offload related to an IPIP entry. This always updates decap, and
1539-
* in addition to that it also:
1540-
* @recreate_loopback: recreates the associated loopback RIF
1541-
* @keep_encap: updates next hops that use the tunnel netdevice. This is only
1538+
* __mlxsw_sp_ipip_entry_update_tunnel - Update offload related to IPIP entry.
1539+
* @mlxsw_sp: mlxsw_sp.
1540+
* @ipip_entry: IPIP entry.
1541+
* @recreate_loopback: Recreates the associated loopback RIF.
1542+
* @keep_encap: Updates next hops that use the tunnel netdevice. This is only
15421543
* relevant when recreate_loopback is true.
1543-
* @update_nexthops: updates next hops, keeping the current loopback RIF. This
1544+
* @update_nexthops: Updates next hops, keeping the current loopback RIF. This
15441545
* is only relevant when recreate_loopback is false.
1546+
* @extack: extack.
1547+
*
1548+
* Return: Non-zero value on failure.
15451549
*/
15461550
int __mlxsw_sp_ipip_entry_update_tunnel(struct mlxsw_sp *mlxsw_sp,
15471551
struct mlxsw_sp_ipip_entry *ipip_entry,

0 commit comments

Comments
 (0)