Skip to content

Commit f9b5bf7

Browse files
committed
drm/i915: use drm->debugfs_root for creating debugfs files
Since commit 0b30d57 ("drm/debugfs: rework debugfs directory creation v5") we should be using drm->debugfs_root instead of minor->debugfs_root for creating debugfs files. Reviewed-by: Luca Coelho <luciano.coelho@intel.com> Link: https://lore.kernel.org/r/ba8a2a7ec10e54b4d0a96926ef20c96e268c0b94.1753782998.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent c5b9077 commit f9b5bf7

File tree

5 files changed

+21
-22
lines changed

5 files changed

+21
-22
lines changed

drivers/gpu/drm/i915/gt/intel_gt_debugfs.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,15 @@ static void gt_debugfs_register(struct intel_gt *gt, struct dentry *root)
8282

8383
void intel_gt_debugfs_register(struct intel_gt *gt)
8484
{
85+
struct dentry *debugfs_root = gt->i915->drm.debugfs_root;
8586
struct dentry *root;
8687
char gtname[4];
8788

88-
if (!gt->i915->drm.primary->debugfs_root)
89+
if (!debugfs_root)
8990
return;
9091

9192
snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
92-
root = debugfs_create_dir(gtname, gt->i915->drm.primary->debugfs_root);
93+
root = debugfs_create_dir(gtname, debugfs_root);
9394
if (IS_ERR(root))
9495
return;
9596

drivers/gpu/drm/i915/i915_debugfs.c

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -720,26 +720,24 @@ static const struct i915_debugfs_files {
720720
{"i915_gem_drop_caches", &i915_drop_caches_fops},
721721
};
722722

723-
void i915_debugfs_register(struct drm_i915_private *dev_priv)
723+
void i915_debugfs_register(struct drm_i915_private *i915)
724724
{
725-
struct drm_minor *minor = dev_priv->drm.primary;
725+
struct dentry *debugfs_root = i915->drm.debugfs_root;
726726
int i;
727727

728-
i915_debugfs_params(dev_priv);
728+
i915_debugfs_params(i915);
729729

730-
debugfs_create_file("i915_forcewake_user", S_IRUSR, minor->debugfs_root,
731-
to_i915(minor->dev), &i915_forcewake_fops);
730+
debugfs_create_file("i915_forcewake_user", S_IRUSR, debugfs_root,
731+
i915, &i915_forcewake_fops);
732732
for (i = 0; i < ARRAY_SIZE(i915_debugfs_files); i++) {
733-
debugfs_create_file(i915_debugfs_files[i].name,
734-
S_IRUGO | S_IWUSR,
735-
minor->debugfs_root,
736-
to_i915(minor->dev),
733+
debugfs_create_file(i915_debugfs_files[i].name, S_IRUGO | S_IWUSR,
734+
debugfs_root, i915,
737735
i915_debugfs_files[i].fops);
738736
}
739737

740738
drm_debugfs_create_files(i915_debugfs_list,
741739
ARRAY_SIZE(i915_debugfs_list),
742-
minor->debugfs_root, minor);
740+
debugfs_root, i915->drm.primary);
743741

744-
i915_gpu_error_debugfs_register(dev_priv);
742+
i915_gpu_error_debugfs_register(i915);
745743
}

drivers/gpu/drm/i915/i915_debugfs_params.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,11 @@ i915_debugfs_create_charp(const char *name, umode_t mode,
248248
/* add a subdirectory with files for each i915 param */
249249
struct dentry *i915_debugfs_params(struct drm_i915_private *i915)
250250
{
251-
struct drm_minor *minor = i915->drm.primary;
251+
struct dentry *debugfs_root = i915->drm.debugfs_root;
252252
struct i915_params *params = &i915->params;
253253
struct dentry *dir;
254254

255-
dir = debugfs_create_dir("i915_params", minor->debugfs_root);
255+
dir = debugfs_create_dir("i915_params", debugfs_root);
256256
if (IS_ERR(dir))
257257
return dir;
258258

drivers/gpu/drm/i915/i915_gpu_error.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2445,11 +2445,11 @@ static const struct file_operations i915_error_state_fops = {
24452445

24462446
void i915_gpu_error_debugfs_register(struct drm_i915_private *i915)
24472447
{
2448-
struct drm_minor *minor = i915->drm.primary;
2448+
struct dentry *debugfs_root = i915->drm.debugfs_root;
24492449

2450-
debugfs_create_file("i915_error_state", 0644, minor->debugfs_root, i915,
2450+
debugfs_create_file("i915_error_state", 0644, debugfs_root, i915,
24512451
&i915_error_state_fops);
2452-
debugfs_create_file("i915_gpu_info", 0644, minor->debugfs_root, i915,
2452+
debugfs_create_file("i915_gpu_info", 0644, debugfs_root, i915,
24532453
&i915_gpu_info_fops);
24542454
}
24552455

drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,17 @@ DEFINE_SIMPLE_ATTRIBUTE(pxp_terminate_fops, pxp_terminate_get, pxp_terminate_set
6969

7070
void intel_pxp_debugfs_register(struct intel_pxp *pxp)
7171
{
72-
struct drm_minor *minor;
72+
struct dentry *debugfs_root;
7373
struct dentry *pxproot;
7474

7575
if (!intel_pxp_is_supported(pxp))
7676
return;
7777

78-
minor = pxp->ctrl_gt->i915->drm.primary;
79-
if (!minor->debugfs_root)
78+
debugfs_root = pxp->ctrl_gt->i915->drm.debugfs_root;
79+
if (!debugfs_root)
8080
return;
8181

82-
pxproot = debugfs_create_dir("pxp", minor->debugfs_root);
82+
pxproot = debugfs_create_dir("pxp", debugfs_root);
8383
if (IS_ERR(pxproot))
8484
return;
8585

0 commit comments

Comments
 (0)