Skip to content

Commit f9f221c

Browse files
rleonSaeed Mahameed
authored andcommitted
xfrm: get global statistics from the offloaded device
Iterate over all SAs in order to fill global IPsec statistics. Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
1 parent fd2bc41 commit f9f221c

File tree

4 files changed

+19
-1
lines changed

4 files changed

+19
-1
lines changed

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -991,7 +991,8 @@ static void mlx5e_xfrm_update_stats(struct xfrm_state *x)
991991
u64 packets, bytes, lastuse;
992992

993993
lockdep_assert(lockdep_is_held(&x->lock) ||
994-
lockdep_is_held(&dev_net(x->xso.real_dev)->xfrm.xfrm_cfg_mutex));
994+
lockdep_is_held(&dev_net(x->xso.real_dev)->xfrm.xfrm_cfg_mutex) ||
995+
lockdep_is_held(&dev_net(x->xso.real_dev)->xfrm.xfrm_state_lock));
995996

996997
if (x->xso.flags & XFRM_DEV_OFFLOAD_FLAG_ACQ ||
997998
x->xso.type != XFRM_DEV_OFFLOAD_PACKET)

include/net/xfrm.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,10 @@
5151

5252
#ifdef CONFIG_XFRM_STATISTICS
5353
#define XFRM_INC_STATS(net, field) SNMP_INC_STATS((net)->mib.xfrm_statistics, field)
54+
#define XFRM_ADD_STATS(net, field, val) SNMP_ADD_STATS((net)->mib.xfrm_statistics, field, val)
5455
#else
5556
#define XFRM_INC_STATS(net, field) ((void)(net))
57+
#define XFRM_ADD_STATS(net, field, val) ((void)(net))
5658
#endif
5759

5860

@@ -1577,6 +1579,7 @@ struct xfrm_state *xfrm_stateonly_find(struct net *net, u32 mark, u32 if_id,
15771579
struct xfrm_state *xfrm_state_lookup_byspi(struct net *net, __be32 spi,
15781580
unsigned short family);
15791581
int xfrm_state_check_expire(struct xfrm_state *x);
1582+
void xfrm_state_update_stats(struct net *net);
15801583
#ifdef CONFIG_XFRM_OFFLOAD
15811584
static inline void xfrm_dev_state_update_stats(struct xfrm_state *x)
15821585
{

net/xfrm/xfrm_proc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ static int xfrm_statistics_seq_show(struct seq_file *seq, void *v)
5252

5353
memset(buff, 0, sizeof(unsigned long) * LINUX_MIB_XFRMMAX);
5454

55+
xfrm_state_update_stats(net);
5556
snmp_get_cpu_field_batch(buff, xfrm_mib_list,
5657
net->mib.xfrm_statistics);
5758
for (i = 0; xfrm_mib_list[i].name; i++)

net/xfrm/xfrm_state.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1957,6 +1957,19 @@ int xfrm_state_check_expire(struct xfrm_state *x)
19571957
}
19581958
EXPORT_SYMBOL(xfrm_state_check_expire);
19591959

1960+
void xfrm_state_update_stats(struct net *net)
1961+
{
1962+
struct xfrm_state *x;
1963+
int i;
1964+
1965+
spin_lock_bh(&net->xfrm.xfrm_state_lock);
1966+
for (i = 0; i <= net->xfrm.state_hmask; i++) {
1967+
hlist_for_each_entry(x, net->xfrm.state_bydst + i, bydst)
1968+
xfrm_dev_state_update_stats(x);
1969+
}
1970+
spin_unlock_bh(&net->xfrm.xfrm_state_lock);
1971+
}
1972+
19601973
struct xfrm_state *
19611974
xfrm_state_lookup(struct net *net, u32 mark, const xfrm_address_t *daddr, __be32 spi,
19621975
u8 proto, unsigned short family)

0 commit comments

Comments
 (0)