scsi: megaraid_sas: Do not log an error if FW successfully initializes.

vinsonlee · martinkpetersen · commit fb1633d56b00 · 2018-04-18T23:37:40.000-04:00
Fixes: 2d2c233 ("scsi: megaraid_sas: modified few prints in OCR and IOC INIT path") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Acked-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -1124,12 +1124,12 @@ megasas_ioc_init_fusion(struct megasas_instance *instance)
 		goto fail_fw_init;
 	}
 
-	ret = 0;
+	return 0;
 
 fail_fw_init:
 	dev_err(&instance->pdev->dev,
-		"Init cmd return status %s for SCSI host %d\n",
-		ret ? "FAILED" : "SUCCESS", instance->host->host_no);
+		"Init cmd return status FAILED for SCSI host %d\n",
+		instance->host->host_no);
 
 	return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -1124,12 +1124,12 @@ megasas_ioc_init_fusion(struct megasas_instance *instance)`
`1124`	`1124`	`goto fail_fw_init;`
`1125`	`1125`	`}`
`1126`	`1126`
`1127`		`- ret = 0;`
	`1127`	`+ return 0;`
`1128`	`1128`
`1129`	`1129`	`fail_fw_init:`
`1130`	`1130`	`dev_err(&instance->pdev->dev,`
`1131`		`- "Init cmd return status %s for SCSI host %d\n",`
`1132`		`- ret ? "FAILED" : "SUCCESS", instance->host->host_no);`
	`1131`	`+ "Init cmd return status FAILED for SCSI host %d\n",`
	`1132`	`+ instance->host->host_no);`
`1133`	`1133`
`1134`	`1134`	`return ret;`
`1135`	`1135`	`}`