Skip to content

Commit fce5729

Browse files
Wesley Chenggregkh
authored andcommitted
usb: host: xhci-mem: Allow for interrupter clients to choose specific index
Some clients may operate only on a specific XHCI interrupter instance. Allow for the associated class driver to request for the interrupter that it requires. Tested-by: Puma Hsu <pumahsu@google.com> Tested-by: Daehwan Jung <dh10.jung@samsung.com> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com> Acked-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20250409194804.3773260-4-quic_wcheng@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5beb4a5 commit fce5729

File tree

4 files changed

+19
-14
lines changed

4 files changed

+19
-14
lines changed

drivers/usb/host/xhci-mem.c

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2331,30 +2331,34 @@ xhci_add_interrupter(struct xhci_hcd *xhci, struct xhci_interrupter *ir,
23312331

23322332
struct xhci_interrupter *
23332333
xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
2334-
u32 imod_interval)
2334+
u32 imod_interval, unsigned int intr_num)
23352335
{
23362336
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
23372337
struct xhci_interrupter *ir;
23382338
unsigned int i;
23392339
int err = -ENOSPC;
23402340

2341-
if (!xhci->interrupters || xhci->max_interrupters <= 1)
2341+
if (!xhci->interrupters || xhci->max_interrupters <= 1 ||
2342+
intr_num >= xhci->max_interrupters)
23422343
return NULL;
23432344

23442345
ir = xhci_alloc_interrupter(xhci, segs, GFP_KERNEL);
23452346
if (!ir)
23462347
return NULL;
23472348

23482349
spin_lock_irq(&xhci->lock);
2349-
2350-
/* Find available secondary interrupter, interrupter 0 is reserved for primary */
2351-
for (i = 1; i < xhci->max_interrupters; i++) {
2352-
if (xhci->interrupters[i] == NULL) {
2353-
err = xhci_add_interrupter(xhci, ir, i);
2354-
break;
2350+
if (!intr_num) {
2351+
/* Find available secondary interrupter, interrupter 0 is reserved for primary */
2352+
for (i = 1; i < xhci->max_interrupters; i++) {
2353+
if (!xhci->interrupters[i]) {
2354+
err = xhci_add_interrupter(xhci, ir, i);
2355+
break;
2356+
}
23552357
}
2358+
} else {
2359+
if (!xhci->interrupters[intr_num])
2360+
err = xhci_add_interrupter(xhci, ir, intr_num);
23562361
}
2357-
23582362
spin_unlock_irq(&xhci->lock);
23592363

23602364
if (err) {
@@ -2370,7 +2374,7 @@ xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
23702374
i, imod_interval);
23712375

23722376
xhci_dbg(xhci, "Add secondary interrupter %d, max interrupters %d\n",
2373-
i, xhci->max_interrupters);
2377+
ir->intr_num, xhci->max_interrupters);
23742378

23752379
return ir;
23762380
}

drivers/usb/host/xhci-sideband.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(xhci_sideband_get_event_buffer);
259259
*/
260260
int
261261
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
262-
bool ip_autoclear, u32 imod_interval)
262+
bool ip_autoclear, u32 imod_interval, int intr_num)
263263
{
264264
int ret = 0;
265265

@@ -273,7 +273,8 @@ xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
273273
}
274274

275275
sb->ir = xhci_create_secondary_interrupter(xhci_to_hcd(sb->xhci),
276-
num_seg, imod_interval);
276+
num_seg, imod_interval,
277+
intr_num);
277278
if (!sb->ir) {
278279
ret = -ENOMEM;
279280
goto out;

drivers/usb/host/xhci.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1853,7 +1853,7 @@ void xhci_free_container_ctx(struct xhci_hcd *xhci,
18531853
struct xhci_container_ctx *ctx);
18541854
struct xhci_interrupter *
18551855
xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
1856-
u32 imod_interval);
1856+
u32 imod_interval, unsigned int intr_num);
18571857
void xhci_remove_secondary_interrupter(struct usb_hcd
18581858
*hcd, struct xhci_interrupter *ir);
18591859
void xhci_skip_sec_intr_events(struct xhci_hcd *xhci,

include/linux/usb/xhci-sideband.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ struct sg_table *
6666
xhci_sideband_get_event_buffer(struct xhci_sideband *sb);
6767
int
6868
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
69-
bool ip_autoclear, u32 imod_interval);
69+
bool ip_autoclear, u32 imod_interval, int intr_num);
7070
void
7171
xhci_sideband_remove_interrupter(struct xhci_sideband *sb);
7272
int

0 commit comments

Comments
 (0)