net/core: remove explicit do_softirq() from busy_poll_stop()

Sebastian Siewior · davem330 · commit fe420d87bbc2 · 2017-06-20T13:09:33.000-04:00
Since commit 217f697 ("net: busy-poll: allow preemption in sk_busy_loop()") there is an explicit do_softirq() invocation after local_bh_enable() has been invoked. I don't understand why we need this because local_bh_enable() will invoke do_softirq() once the softirq counter reached zero and we have softirq-related work pending. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/core/dev.c b/net/core/dev.c
@@ -5206,8 +5206,6 @@ static void busy_poll_stop(struct napi_struct *napi, void *have_poll_lock)
 	if (rc == BUSY_POLL_BUDGET)
 		__napi_schedule(napi);
 	local_bh_enable();
-	if (local_softirq_pending())
-		do_softirq();
 }
 
 void napi_busy_loop(unsigned int napi_id,

Original file line number	Diff line number	Diff line change
`@@ -5206,8 +5206,6 @@ static void busy_poll_stop(struct napi_struct napi, void have_poll_lock)`
`5206`	`5206`	`if (rc == BUSY_POLL_BUDGET)`
`5207`	`5207`	`__napi_schedule(napi);`
`5208`	`5208`	`local_bh_enable();`
`5209`		`- if (local_softirq_pending())`
`5210`		`- do_softirq();`
`5211`	`5209`	`}`
`5212`	`5210`
`5213`	`5211`	`void napi_busy_loop(unsigned int napi_id,`