Skip to content

Commit ff89a4d

Browse files
BailyBairodrigovivi
authored andcommitted
drm/xe/sysfs: Add cleanup action in xe_device_sysfs_init
On partial failure, some sysfs files created before the failure might not be removed. Add common cleanup step to remove them all immediately, as is should be harmless to attempt to remove non-existing files. Fixes: 0e414bf ("drm/xe: Expose PCIe link downgrade attributes") Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Stuart Summers <stuart.summers@intel.com> Cc: Shuicheng Lin <shuicheng.lin@intel.com> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com> Signed-off-by: Zongyao Bai <zongyao.bai@intel.com> Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Link: https://lore.kernel.org/r/20250915214716.1327379-2-zongyao.bai@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> (cherry picked from commit 1a86916) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent cbc7f3b commit ff89a4d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/gpu/drm/xe/xe_device_sysfs.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,12 +311,16 @@ int xe_device_sysfs_init(struct xe_device *xe)
311311
if (xe->info.platform == XE_BATTLEMAGE) {
312312
ret = sysfs_create_files(&dev->kobj, auto_link_downgrade_attrs);
313313
if (ret)
314-
return ret;
314+
goto cleanup;
315315

316316
ret = late_bind_create_files(dev);
317317
if (ret)
318-
return ret;
318+
goto cleanup;
319319
}
320320

321321
return devm_add_action_or_reset(dev, xe_device_sysfs_fini, xe);
322+
323+
cleanup:
324+
xe_device_sysfs_fini(xe);
325+
return ret;
322326
}

0 commit comments

Comments
 (0)