Skip to content

Conversation

alexanderchiu
Copy link
Contributor

@alexanderchiu alexanderchiu commented Oct 9, 2025

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Pass CUBEJS_DB_QUERY_TIMEOUT variable through as https://docs.firebolt.io/reference/system-settings#statement-timeout to Firebolt so that query cancellation works correctly.

Example curl:

curl --location 'https://XXXXX.api.eu-west-1.app.firebolt.io/?database=XXXXX\&output_format=JSON_Compact&engine=test_engine&statement_timeout=1000' \
--header 'Authorization: Bearer XXXXXXX' \
--data 'SELECT checksum(*) FROM GENERATE_SERIES(1, 1000000000000);'
{
  "errors": [
    {
      "description": "Query was canceled with reason 'Query timeout expired (1000 ms)'"
    }
  ],
  "query": {
    "query_id": "def8ff9a-3f85-4c89-ac41-030cb56bfa19",
    "query_label": null,
    "request_id": "7159c249-edc3-42f0-a518-4b5d13bc05f3"
  },
  "statistics": {
    "elapsed": 0.0
  }
}

@alexanderchiu alexanderchiu requested a review from a team as a code owner October 9, 2025 07:46
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 9, 2025
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexanderchiu thank you for this contribution!

@alexanderchiu
Copy link
Contributor Author

Hi @alexanderchiu thank you for this contribution!

And thanks for the quick review!

@KSDaemon KSDaemon merged commit b46565b into cube-js:master Oct 9, 2025
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

driver:firebolt pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants