Skip to content

Conversation

@MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR pushes year-month and year-month-day IN number filters to CubeScan. Those are generated by Tableau.
Related tests are included.

…ubeScan

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou requested a review from a team as a code owner October 20, 2025 16:52
@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 97.23183% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (6034850) to head (9f38839).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 96.34% 6 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 98.40% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10068      +/-   ##
==========================================
+ Coverage   83.24%   83.29%   +0.04%     
==========================================
  Files         244      244              
  Lines       73483    73759     +276     
==========================================
+ Hits        61172    61435     +263     
- Misses      12311    12324      +13     
Flag Coverage Δ
cubesql 83.29% <97.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit bc16a5f into master Oct 21, 2025
273 of 289 checks passed
@MazterQyou MazterQyou deleted the cubesql/tableau-year-month-day-in-number branch October 21, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants