Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Oct 20, 2025

Allow to merge week granularity date_part filter into inDateRange.

@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.19%. Comparing base (bcadbf2) to head (8cbac78).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...cubesql/cubesql/src/compile/rewrite/rules/utils.rs 93.33% 7 Missing ⚠️
...besql/cubesql/src/compile/rewrite/rules/filters.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10071      +/-   ##
==========================================
+ Coverage   77.14%   77.19%   +0.05%     
==========================================
  Files         440      440              
  Lines       89413    89580     +167     
  Branches     3101     3101              
==========================================
+ Hits        68980    69155     +175     
+ Misses      20044    20036       -8     
  Partials      389      389              
Flag Coverage Δ
cube-backend 48.77% <ø> (ø)
cubesql 83.29% <96.29%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ovr ovr force-pushed the feat/cubesql-filter-pushdown-merge-year-week branch from 1649574 to c8e7b65 Compare October 20, 2025 21:27
@ovr ovr marked this pull request as ready for review October 20, 2025 22:23
@ovr ovr requested a review from a team as a code owner October 20, 2025 22:23
@ovr ovr merged commit 150a3c5 into master Oct 21, 2025
83 of 86 checks passed
@ovr ovr deleted the feat/cubesql-filter-pushdown-merge-year-week branch October 21, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants