Skip to content

Conversation

@igorlukanin
Copy link
Member

No description provided.

@igorlukanin igorlukanin requested a review from a team as a code owner November 19, 2025 16:41
@github-actions github-actions bot added driver:prestodb Issues relating to the PrestoDB driver javascript Pull requests that update Javascript code data source driver labels Nov 19, 2025
@igorlukanin igorlukanin changed the title fix(trino-driver, presto-driver): Qualify information schema queries … fix(trino-driver, presto-driver): Qualify information schema queries with a catalog name Nov 19, 2025
Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, these are kind of the same queries as in BaseQuery, just prefixed with the catalog name, right?

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.64%. Comparing base (d6b4c21) to head (612a709).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/cubejs-prestodb-driver/src/PrestoDriver.ts 9.09% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10158      +/-   ##
==========================================
- Coverage   54.72%   54.64%   -0.09%     
==========================================
  Files         213      214       +1     
  Lines       16912    16993      +81     
  Branches     3337     3471     +134     
==========================================
+ Hits         9255     9285      +30     
- Misses       7179     7208      +29     
- Partials      478      500      +22     
Flag Coverage Δ
cube-backend 54.64% <9.09%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon merged commit 9cb11bc into master Nov 24, 2025
36 checks passed
@KSDaemon KSDaemon deleted the fix-trino-information-schema-query branch November 24, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data source driver driver:prestodb Issues relating to the PrestoDB driver javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants