Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 25, 2025

  • fix(schema-compiler): Fix matching for pre-aggs with custom granularities
  • add tests

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.64%. Comparing base (4f9ccba) to head (7085805).
⚠️ Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4f9ccba) and HEAD (7085805). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (4f9ccba) HEAD (7085805)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10180       +/-   ##
===========================================
- Coverage   77.94%   54.64%   -23.31%     
===========================================
  Files         458      214      -244     
  Lines       91218    16996    -74222     
  Branches     3471     3472        +1     
===========================================
- Hits        71098     9287    -61811     
+ Misses      19620     7208    -12412     
- Partials      500      501        +1     
Flag Coverage Δ
cube-backend 54.64% <100.00%> (-0.01%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review November 25, 2025 19:13
@KSDaemon KSDaemon requested a review from a team as a code owner November 25, 2025 19:13
@KSDaemon KSDaemon merged commit e426f6b into master Nov 26, 2025
110 of 112 checks passed
@KSDaemon KSDaemon deleted the fix/pre-agg-matching branch November 26, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants