Skip to content

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Dec 4, 2025

This PR allows ordering by some measure(s) that is(are) not included in the selection list. Previously, such an order by clause was simply omitted.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.26%. Comparing base (52fe97f) to head (ac6f088).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10218      +/-   ##
==========================================
+ Coverage   77.93%   83.26%   +5.32%     
==========================================
  Files         465      246     -219     
  Lines       91306    74246   -17060     
  Branches     3487        0    -3487     
==========================================
- Hits        71160    61821    -9339     
+ Misses      19648    12425    -7223     
+ Partials      498        0     -498     
Flag Coverage Δ
cube-backend ?
cubesql 83.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review December 4, 2025 11:00
@KSDaemon KSDaemon merged commit 2efb5ec into master Dec 4, 2025
95 of 97 checks passed
@KSDaemon KSDaemon deleted the fix/orderby-not-included branch December 4, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants