Skip to content

Conversation

konserw
Copy link
Contributor

@konserw konserw commented Mar 14, 2016

New fixed and rebased version of windows CI

@konserw konserw mentioned this pull request Mar 14, 2016
@konserw
Copy link
Contributor Author

konserw commented Mar 15, 2016

It was broken because Windoze doesn't recognize any signal except of "KILL" see Probably this is M$ "feature" ;/

@konserw
Copy link
Contributor Author

konserw commented Mar 15, 2016

Ok, I've cleaned up this PR, both CI are green, now only thing left is cucumber-tck changes.

@paoloambrosio
Copy link
Member

Tried it on Windows 10 + VS 2015. I get "C:\Libraries\boost_1_60_0\boost/config/auto_link.hpp(365): fatal error C1189: #error: "Mixing a dll boost library with a static runtime is a really bad idea..."


(Get-Content $path) -replace '\ST\DERR.puts %', '#nope' | Set-Content $path
(Get-Content $path) -replace ' Cucumber::', '#nope' | Set-Content $path
(Get-Content $path) -replace '^Cucumber::', '#nope' | Set-Content $path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix a problem in Cucumber 2.0.0... is it a documented problem? Can you post a link? Does it happen with Ruby 2.2 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more of a problem of how appveyor is implemented, i.e. it doesn't need any additional library to get colored output - just like on *nix - and cucumber thinks it is not possible on windows. See:
appveyor/ci#373
http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes
It's not dependent on ruby version.

Bjorn Rasmusson wrote:

Cucumber-ruby v2.1.0 (and later) use Gherkin3, so to use a newer Ruby version on Windows, you need to update to a newer Cucumber-ruby version.

But AFAIR I tried newer cucumber-ruby and failed (when searching newest working ruby germs).

@paoloambrosio
Copy link
Member

I also get

CMake Warning at CMakeLists.txt:197 (message):
  Could not find Cucumber: skipping end-to-end tests

if I don't install Cucumber-Ruby before running CMake (like you do in your script).

@konserw
Copy link
Contributor Author

konserw commented Mar 16, 2016

About cuvumber-ruby - have you done bundle install ?

@konserw
Copy link
Contributor Author

konserw commented Mar 16, 2016

Ok, now I believe it can be merged.

@konserw
Copy link
Contributor Author

konserw commented Mar 17, 2016

Abot that:

Tried it on Windows 10 + VS 2015. I get "C:\Libraries\boost_1_60_0\boost/config/auto_link.hpp(365): fatal error C1189: #error: "Mixing a dll boost library with a static runtime is a really bad idea..."

I've also done some tests and I don't know how to enable boost test on windows properly - this is why i've added -DCUKE_DISABLE_BOOST_TEST in my appveyor config.

All in all it seems to me that boost test is really problematic to use...

@paoloambrosio paoloambrosio modified the milestone: v0.3.1 Mar 26, 2016
@paoloambrosio
Copy link
Member

Spent a few (horrible) days on Windows to fix the build. Created and merged #113 and then the AppVeyor build #114 was simple. Sorry to reject this PR.

Notes:

  • The E2E suite just needed the full path for Cucumber, without changing run_simple
  • Didn't add any hack for build colours, as they are not important to justify a patch
  • Not sure the build matrix was working since changing the CMake generator should not change the VS used or the architecture (x64 needs Boost lib64, so my guess is that x86 was always used)

@konserw konserw deleted the rebaseapp branch September 28, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants