Skip to content

Conversation

konserw
Copy link
Contributor

@konserw konserw commented Feb 12, 2016

Build cucumber on appveyor - windows CI platform.
Only thing that's not working is features target. I'm not sure how to fix this. Probably it has somethik do to with naming of targets (see test target)

This is rebased, shortened version of my appveyor_old branch - if you want to know how i came up with all this strange things feel free to examine over 50 commits there: https://github.com/konserw/cucumber-cpp/tree/appveyor_old

@konserw
Copy link
Contributor Author

konserw commented Feb 27, 2016

I'm curently working on enabling features target on windows but it is very troublesome, see for example:
http://www.tylerthrailkill.com/blog/aruba-and-windows/

endif()
set(Boost_USE_STATIC_LIBS ON)
set(Boost_USE_STATIC_RUNTIME ON)
set (Boost_MULTITHREADED ON)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to static linking and to the Windows build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - on windows only way I could get it running was to statically (with multithread - /MT) link everything

@konserw
Copy link
Contributor Author

konserw commented Mar 1, 2016

This PR has a massive number of commits and can't possibly be merged. What I usually do is to try this on a branch before sending the PR, and keep PRs with a small number of relevant commits.

Let's review it here first though, to try and get it to a better state before sending another PR :-)

This is also what I've done - see branches appveyor_old and app :)
Commit count and LOC will drop if you merge #93 but I agree that some rebasing might be in order ;)
When I submited this PR I was hoping for some review and help with getting working features target.

@konserw
Copy link
Contributor Author

konserw commented Mar 3, 2016

Commit 844b720 broken appveyor build - not sure why, but after it was reverted everything is OK :)
Anything else to fix?

@konserw
Copy link
Contributor Author

konserw commented Mar 11, 2016

I've tried rebasing this PR in branch app and this is result:
https://ci.appveyor.com/project/konserw/cucumber-cpp/build/app-ci-108/job/egkn985xxwjoelth
It's broken because of Commit 844b720 steps process is not being killed. Have you got any idea why?

@konserw
Copy link
Contributor Author

konserw commented Mar 14, 2016

Ok, It wasn't fault of that commit.
Revised version of this PR is #108. I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants