Skip to content

Conversation

vincent-psarga
Copy link
Contributor

@vincent-psarga vincent-psarga commented Oct 16, 2019

Summary

Preparation for release 4.0
Remove dots-formatter as this uses the Go implementation

This PR goes alongside:

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Remove dots-formatter: this is still using Go implementation and we will not use it for version 4
Though, I don't like the idea of disabling Metrics/ClassLength for the
pretty class.
We should spend time making the code more Rubocop friendly, but another time.
@vincent-psarga
Copy link
Contributor Author

I agree, but the purpose here is just to illustrate/test the syntax, not necessarily to give a good example of use.

Well, if we can do both at once, I'd say why not :)

It makes me think, I'm wondering about refactoring the existing features inside the features/docs folder so it uses the new syntax.
It can be pretty confusing for the users to have features using the Scenario keyword and the other one using the Example one. Which one is correct ? (well, both of them but still, being consistent would be great).
Same thing for the Scenario Outline.

@vincent-psarga vincent-psarga merged commit ee78891 into master Oct 31, 2019
@luke-hill luke-hill deleted the gherkin-8 branch January 9, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants