Gherkin update #59
Merged
Gherkin update #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaindocs
reviewed
Nov 6, 2017
content/gherkin/gherkin-reference.md
Outdated
| allow concise description of examples to illustrate business rules in most real-world | ||
| domains. | ||
| domains. It is structured enough for a tool like Cucumber to process. |
There was a problem hiding this comment.
How about
Gherkin is designed to be easy for people to read and write, yet structured enough to
to allow for automated processing and concise description of business rules.
plaindocs
reviewed
Nov 6, 2017
content/gherkin/gherkin-reference.md
Outdated
|
|
||
| Cucumber does not care about the name or the description. Their purpose is simply to provide a place for you to document important aspects of the Feature, such as a brief explanation and a list of business rules (general acceptance criteria). | ||
| Cucumber does not care about the name or the description. |
There was a problem hiding this comment.
Slightly wary of "does not care" here. Can we reword?
Also remove "simply" ?
There was a problem hiding this comment.
Changed to: "The name and the description have no special meaning to Cucumber." (and removed "simply").
Let me know if anyone has a better idea
|
Otherwise looks great. |
1 task
This was referenced Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge feature-introduction into gherkin-reference
Update links
Merge info from cucumber/common#68 into introduction