Repository navigation
v1.21.0
TREE-COMPARISON is generated, and waits for the merge. Golden e2e findings #1 and #5 (#20).
- The problem, measured. In the 12 RUN CONTRACTs kept from golden e2e runs of one ticket, the floor
condition'scheckmeant one of two things:- 4 compared the base to the branch. That is the condition's intended meaning (envelope test T5),
but before the merge it is BROKEN by construction, so every correctautorunclosed onq > 0. - 8 compared the remote branch to the local one. That holds at close, but it repeats
LOCAL-HEAD-PUSHED, and it HOLDS on a correction pushed after the merge, the incident the condition
exists for. That is a false green. - Every one of the 12 passed the old contract checks, which looked only for
git diff --quietand
refused a grep or an ancestry predicate. The path list took 4 shapes and thebaseheader 5.
- 4 compared the base to the branch. That is the condition's intended meaning (envelope test T5),
- A — the floor checks are generated.
run_contract.py writerendersTREE-COMPARISONas
git diff --quiet <remote>/<base-branch> <remote>/<branch> -- UNBOUND ${CHANGED_PATHS}. It renders
LOCAL-HEAD-PUSHEDas arev-parse --verifycomparison ofrefs/heads/<branch>with
refs/remotes/<remote>/<branch>.- A spec or contract carrying any other spelling is refused (exit 2), never silently corrected.
baseis now<branch>@<sha>, its sha derived bygit rev-parse. A supplied sha the repo
contradicts is refused.branchandremotemust be plain ref names, because they reach a shell.CHANGED_PATHSis bound at Gate 2 to the approved change list, plain path tokens only.- The grep and ancestry refusals are kept.
- B —
pending-mergeand--phase post-merge.- The RECONCILE line gains a seventh axis:
… | <c> could-not-run | <w> pending-merge. - At
close,TREE-COMPARISONis not run and is countedpending-merge: never holding, and never
reported as verified. --phase post-mergeruns every condition. A BROKEN there prints READ THIS FIRST; a ref that did
not resolve (a remote branch deleted at merge and pruned) is named as unverified.- An unknown phase is refused.
t0is unchanged. - The DISCLOSURE seed adds a
POST-MERGEline carrying the exact command (git fetch <remote>, then
reconcile.py run <contract> --phase post-merge).autorunputs it in the PR body and does not
run it itself.
- The RECONCILE line gains a seventh axis:
- The golden e2e judge now requires the contract to validate at close and re-runs RECONCILE at
post-mergeafter its simulated squash. Every condition must hold, with nonepending-merge. - Incompatible with older contracts. A ≤ 1.20.0 contract carries an authored check and a free-form
base, so 1.21.0 refuses it. This matters only for a run that spans a plugin upgrade, and the
contract'splugin-versionnames the cause. - Tests and enforcement:
validate.pyenforces each item above.- Envelope tests:
- render and refuse;
- every observed free-form
baseand both observed tree forms; - pending-merge at close, and post-merge HOLDING after a squash;
- post-merge BROKEN on a correction pushed after merge, with the refused form shown HOLDING on that
same correction; - t0 unchanged, and the disclosure line.