This repository was archived by the owner on Aug 27, 2022. It is now read-only.
Fix excluding IPs #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that everything's in a try block continue doesn't work. Raising an exception was the easiest way to fix the functionality however removing the for loop from the try block and using a separate try block inside the for loop is also an option. Also, noticed a couple typos.
|
Wouldn't this cause it to produce an error? |
|
In the log? You have lines 346-347 to just pass on exception and not log anything so I don't think any errors would be exposed to the user. (EDIT: I should clarify - in my testing I'm not seeing any errors. I'm by no means a python pro but as far as I know there shouldn't be any errors produced due the your exception handling) Like I said, this was just the easiest fix without changing any of your logic. If you want me to take a different approach that's fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that everything's in a try block continue doesn't work. Raising an exception was the easiest way to fix the functionality however removing the for loop from the try block and using a separate try block inside the for loop is also an option. Also, noticed a couple typos.