-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearpath Heron USV #6548
base: master
Are you sure you want to change the base?
Clearpath Heron USV #6548
Conversation
There are several errors reported by the CI on the "Test Sources". In particular:
Can you please fix them? |
I fix that bugs @omichel |
Thank you. Could you please also write a short documentation? This is required for robots distributed in Webots. |
@omichel I finish all of for document, can you check ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop.dae doesn't seem to be used and should be removed.
The bounding object (heron_collision.stl) should not be made up of STL file, but simply boxes which will be much more efficient and less buggy.
The PROTO and world files should not contain any linearVelocity or angularVelocity fields.
If I integrate the heron collision file, the vehicle cannot turn left or right at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of storing the stl files in an obj folder, it would be better to store them in a stl folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image of the robot is a bit small here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not be a picture of the real robot, but a picture of the simulated robot, which is larger that the one you originally committed.
okey sir. |
mr. @omichel , can you check ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, I would also appreciate if you can fix the icon which should be a screenshot of the simulated robot, not the real one.
linearVelocity_0 7.738948701030327e-55 -4.450876199231589e-55 2.819335278757325e-06 | ||
angularVelocity_0 -0.0010746087365596433 -0.0018872241483721332 -8.299049855187801e-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove also all these linearVelocity_0 and angularVelocity_0 parameters which are useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you should really remove these lines, not replace them.
Also, please update the icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my latest comment.
Description
Clearpath's USV vehicle named Heron has been added.
Tasks
Add the list of tasks of this PR.
Screenshots