Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearpath Heron USV #6548

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

harunkurtdev
Copy link

Description
Clearpath's USV vehicle named Heron has been added.

Tasks
Add the list of tasks of this PR.

  • New Robot

Screenshots
ocean
swarm

@harunkurtdev harunkurtdev requested a review from a team as a code owner May 11, 2024 13:01
@omichel
Copy link
Member

omichel commented May 11, 2024

There are several errors reported by the CI on the "Test Sources". In particular:

/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:29:1: W293: blank line contains whitespace
/home/runner/work/webots/webots/projects/robots/clearpath/heron/controllers/heron_usv_controller/heron_usv_controller.py:46:1: W293: blank line contains whitespace
Missing ".wproj" file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/worlds/.swarm.wbproj"
Wrong line ending in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/obj/boat.obj"
missing icon: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"
Wrong header in file: "/home/runner/work/webots/webots/projects/robots/clearpath/heron/protos/Heron.proto"

etc.

Can you please fix them?

@harunkurtdev
Copy link
Author

I fix that bugs @omichel

@omichel
Copy link
Member

omichel commented May 13, 2024

Thank you. Could you please also write a short documentation? This is required for robots distributed in Webots.

@harunkurtdev
Copy link
Author

@omichel I finish all of for document, can you check ?

@ShuffleWire ShuffleWire mentioned this pull request Aug 8, 2024
48 tasks
@harunkurtdev
Copy link
Author

@omichel sir can you check ? #6597

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop.dae doesn't seem to be used and should be removed.
The bounding object (heron_collision.stl) should not be made up of STL file, but simply boxes which will be much more efficient and less buggy.
The PROTO and world files should not contain any linearVelocity or angularVelocity fields.

projects/robots/clearpath/heron/protos/docs/heron.md Outdated Show resolved Hide resolved
@harunkurtdev
Copy link
Author

harunkurtdev commented Aug 28, 2024

prop.dae doesn't seem to be used and should be removed.
The bounding object (heron_collision.stl) should not be made up of STL file, but simply boxes which will be much more efficient and less buggy.
The PROTO and world files should not contain any linearVelocity or angularVelocity fields.

If I integrate the heron collision file, the vehicle cannot turn left or right at all.
I changed viscous and etc. a little hard with heron collision file.

image

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of storing the stl files in an obj folder, it would be better to store them in a stl folder.

projects/robots/clearpath/heron/protos/docs/heron.md Outdated Show resolved Hide resolved
projects/robots/clearpath/heron/protos/docs/heron.md Outdated Show resolved Hide resolved
projects/robots/clearpath/heron/protos/Heron.proto Outdated Show resolved Hide resolved
projects/robots/clearpath/heron/protos/Heron.proto Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image of the robot is a bit small here.

Copy link
Author

@harunkurtdev harunkurtdev Oct 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed with this
Heron

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be a picture of the real robot, but a picture of the simulated robot, which is larger that the one you originally committed.

projects/robots/clearpath/heron/worlds/ocean.wbt Outdated Show resolved Hide resolved
projects/robots/clearpath/heron/obj/lidar-rear-plate.stl Outdated Show resolved Hide resolved
@harunkurtdev
Copy link
Author

Instead of storing the stl files in an obj folder, it would be better to store them in a stl folder.

okey sir.

@harunkurtdev
Copy link
Author

mr. @omichel , can you check ?

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, I would also appreciate if you can fix the icon which should be a screenshot of the simulated robot, not the real one.

Comment on lines 41 to 42
linearVelocity_0 7.738948701030327e-55 -4.450876199231589e-55 2.819335278757325e-06
angularVelocity_0 -0.0010746087365596433 -0.0018872241483721332 -8.299049855187801e-20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove also all these linearVelocity_0 and angularVelocity_0 parameters which are useless.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should really remove these lines, not replace them.
Also, please update the icon.

Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my latest comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants