Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Bandwidth Price to Average for 24h Sliding Window #188

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

arturalbov
Copy link
Contributor

Change Bandwidth Price to Average for 24h Sliding Window

@hleb-albau
Copy link
Contributor

  1. I think we should better not to use double float conversion. It is not pure in terms of specification.
    May be we should have 2 methods: GetTxCost() -> int64 and GetPricedTxCost for such cases.
  2. May be use BlockSpentBw as pointer everywhere, instead of making it fields pointers?

@arturalbov
Copy link
Contributor Author

1. I think we should better not to use double float conversion. It is not pure in terms of specification.
   May be we should have 2 methods: **GetTxCost() -> int64** and **GetPricedTxCost** for such cases.

2. May be use  **BlockSpentBw** as pointer everywhere, instead of making it fields pointers?

@hleb-albau updated

@hleb-albau hleb-albau merged commit 97e1d8b into 0.1.1 Jan 24, 2019
@hleb-albau hleb-albau deleted the 179_bandwidth_window branch January 24, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants