Correct Firefox example artifacts and video #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
fix/firefox-snapshots
branch
from
30bf601
to
400108a
Compare
|
I have rebased this PR and aligned the naming of the v9 artifacts to the fact that you renamed the job-id to firefox-v9. Even though this is skipped it makes better reading as an example to have some naming consistency. The remaining effective change in this PR to to disable videos for v10 and therefore suppress the error message about videos. |
MikeMcC399
force-pushed
the
fix/firefox-snapshots
branch
from
400108a
to
fb37c75
Compare
This comment was marked as outdated.
This comment was marked as outdated.
MikeMcC399
force-pushed
the
fix/firefox-snapshots
branch
from
fb37c75
to
95f71d8
Compare
|
I have taken out the
The checks have run successfully, so I'm putting this PR back into review. It should be good to merge. |
MikeMcC399
force-pushed
the
fix/firefox-snapshots
branch
from
95f71d8
to
8832b63
Compare
Correct directory for firefox v9 artifacts upload Separate upload directories Suppress video creation due to Cypress issue 18415
MikeMcC399
force-pushed
the
fix/firefox-snapshots
branch
from
8832b63
to
3f6832c
Compare
jaffrepaul
approved these changes
Jan 10, 2023
|
🎉 This PR is included in version 5.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue #661 "CI: Artifact and video warnings in example-firefox".
It corrects .github/workflows/example-firefox.yml by selecting the right directory to upload the screenshots captured by the Cypress v9 test and makes the name unique under which the artifacts are stored on GitHub.
It disables videos to prevent a video warning message appearing which is a known problem under Firefox (see Video functionality is not working on Firefox 93 and above cypress#18415).
.gitignorefiles are created for both v9 and v10 Firefox tests in case the tests are used locally (rather than in the workflow).Verification
Find a successful run of the workflow example-firefox by searching on https://github.com/cypress-io/github-action/actions/workflows/example-firefox.yml?query=branch%3Amaster
In the "Artifacts" section check that
screenshots-in-firefox-v9andscreenshots-in-firefox-v10have both been uploaded. Download each artifact file and examine the contents.In the logs from
firefox-v9andfirefox-v10select and expand "Firefox". Check that there are no warnings regarding videos.Note: Since PR #660 has now been merged, the
v9test is skipped, and therefore there is noscreenshots-in-firefox-v9artifact uploaded and no detailed logs forfirefox-v9available.