Correct .gitignore for videos and screenshots created by running examples

[MikeMcC399]

This PR resolves issue #676 "locally created screenshots and videos in examples are queued for commit".

It corrects the syntax in .gitignore so that the screenshots and videos directories, which may be created through running examples locally, are correctly found and excluded from any git commit. Additionally the directory downloads is marked for exclusion.

The incorrectly committed directory examples/v10/chrome/cypress/screenshots is removed from the repository.

Verification

1. In a local clone of the repository, execute:

cd examples/v10/quiet
npm ci
npx cypress run --browser chrome
git status

and check that git finds no screenshots or videos to commit

$ git status
On branch master
nothing to commit, working tree clean

2. Check that cypress-io/github-action/examples/v10/chrome/cypress/screenshots no longer exists.

[MikeMcC399]

Note that the line
cypress/videos/
in .gitignore is ineffective and could be removed. It would only match at the top level of the repository, where there is in fact no cypress directory present.

Edit: I decided to remove it. Having it there is misleading as it gives the impression it might be doing something.
node_modules/ finds nested directories because it only has a slash at the end, not in the middle. See reference documentation https://git-scm.com/docs/gitignore for details about how this works.

[jaffrepaul]

Great, thank you.

[MikeMcC399]

@jaffrepaul

Great, thank you.

You're welcome! One of several minor things that just need a bit of attention.

yarn also needs to be dealt with at some stage in .gitignore, but I would separate this out. It only affects two examples. Edit: not necessary for yarn classic (v1).

[github-actions]

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jaffrepaul]

@MikeMcC399 this merge triggered a release. My fault, my plan is to cut a release with everything else we worked on very soon.

[MikeMcC399]

@jaffrepaul

this merge triggered a release. My fault, my plan is to cut a release with everything else we worked on very soon.

Sorry, if this was not in line with your plans. I was the one who added fix: into the commit. It was the first fix which generically affected the repository, the other fixes were about tools or examples tests. I struggled a little deciding in the past whether or not to label something a fix: because the action and examples of using the action are bundled into one repository, so is the version number only supposed to refer to the action or should it also refer to the examples?

I will check with you in future before using any of the release-triggering tags fix: / feat: / perf:.

[jaffrepaul]

@jaffrepaul

this merge triggered a release. My fault, my plan is to cut a release with everything else we worked on very soon.

Sorry, if this was not in line with your plans. I was the one who added fix: into the commit. It was the first fix which generically affected the repository, the other fixes were about tools or examples tests. I struggled a little deciding in the past whether or not to label something a fix: because the action and examples of using the action are bundled into one repository, so is the version number only supposed to refer to the action or should it also refer to the examples?

I will check with you in future before using any of the release-triggering tags fix: / feat: / perf:.

Not a problem. We're juggling a number of repos and I just didn't spot it. I'm happy to accept all the great fixes here, so we get them in even if it's a little clunky. This was a bit out of the normal routine here but I'm putting thought into how to better maintain these repos in the future, including the release strategy ✅

[MikeMcC399]

It's good that you are thinking about improvements. It seems that this repository has gathered dust over time and fixing it is a bit like peeling an onion, with layers of things which need to be looked at. This repository also links to many outdated examples, even non-working ones, in other repositories. These would also need reviewing at some stage.

[jaffrepaul]

Indeed.

Side note, you should join the Cypress Discord server. If you shoot me a DM there, I can look into sending you some Cypress swag 🎉

[MikeMcC399]

@jaffrepaul

Side note, you should join the Cypress Discord server. If you shoot me a DM there, I can look into sending you some Cypress swag 🎉

Thanks for the recognition and offer! I have joined Cypress Discord with the same username as I´m using here on GitHub. I didn´t manage to find you there in order to connect up, so if you could either post your username or DM me, then we can move some of our conversations over there. I won´t be so active the next days though due to the holidays.