Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dala 4732 manual maintenance sprint 74 #641

Merged
merged 34 commits into from
Aug 16, 2024

Conversation

SiegfriedSobkowiak
Copy link
Contributor

@SiegfriedSobkowiak SiegfriedSobkowiak commented Aug 15, 2024

Pull Request <Title>

<Description here>

Things to do during Peer Review

Please check all boxes before the Pull Request is merged. In case you skip a box, describe in the PRs description (that means: here) why the check is skipped.

  • The Github Actions (including Sonarqube Gateway and Lint Checks) are green. This is enforced by Github.
  • A peer-review has been executed
    • The code has been manually inspected by someone who did not implement the feature
    • If this PR includes work on the frontend, at least one @ts-nocheck is removed. Additionally, there should not be any @ts-nocheck in files modified by this PR. If no @ts-nocheck are left: Celebrate 🎉 🎊 type-safety and remove this entry.
  • The PR actually implements what is described in the JIRA-Issue
  • At least one test exists testing the new feature
    • If you have created new test files, make sure that they are included in a test container and actually run in the CI
  • At least 3 consecutive CI runs are successfully executed to ensure that there are no flaky tests.
  • Documentation is updated as required
  • The automated deployment is updated if required
  • If there was a database entity class added, there must also be a migration script for creating the corresponding database if flyway is already used by the service
  • IF there are changes done to the framework data models or to a database entity class, the following steps were completed in order
    • A fresh clone of dataland.com is generated (see Wiki page on "OTC" for details)
    • The feature branch is deployed to clone with Reset non-user related Docker Volumes & Re-populate turned off
    • It's verified that the CD run is green
    • The new feature is manually used/tested/observed on the clone server. Testing of the new feature should (also) be done by a second, independent reviewer from the dev team
    • The feature branch is deployed to dev1 with Reset non-user related Docker Volumes & Re-populate turned on, and it's verified that the CD run is green
  • ELSE, the new version is deployed to the dev server "dev1" using this branch
    • Run with setting Reset non-user related Docker Volumes & Re-populate turned on
    • It's verified that this version actually is the one deployed (check gitinfo for branch name and commit id!)
    • It's verified that the CD run is green
    • The new feature is manually used/tested/observed on dev server. Testing of the new feature should (also) be done by a second, independent reviewer from the dev team

renovate bot and others added 30 commits June 19, 2024 08:56
…' into DALA-4732_manual_maintenance_sprint_74
…-openapi-starter-webmvc-ui-2.x' into DALA-4732_manual_maintenance_sprint_74
…ent' into DALA-4732_manual_maintenance_sprint_74
….x' into DALA-4732_manual_maintenance_sprint_74

# Conflicts:
#	dataland-automated-qa-service/requirements.txt
…epo' into DALA-4732_manual_maintenance_sprint_74
…DALA-4732_manual_maintenance_sprint_74

# Conflicts:
#	dataland-keycloak/dataland_theme/login/package-lock.json
#	dataland-keycloak/dataland_theme/login/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants