Skip to content

Conversation

viqtor
Copy link
Contributor

@viqtor viqtor commented Jul 2, 2021

No description provided.

@viqtor
Copy link
Contributor Author

viqtor commented Jul 2, 2021

follow up to #181

@viqtor
Copy link
Contributor Author

viqtor commented Jul 2, 2021

now thats just typical. "worked on my machine" 😉
let me see if i would be able to reproduce and fix

@dadoonet
Copy link
Owner

dadoonet commented Jul 3, 2021

Would you like to revisit your PR and make it support Java 8 again?

@viqtor viqtor force-pushed the compiler-target branch from fe2cffa to b261d81 Compare July 5, 2021 04:33
@viqtor viqtor changed the title jdk release 11 restore java 8 Jul 5, 2021
@viqtor
Copy link
Contributor Author

viqtor commented Jul 5, 2021

Would you like to revisit your PR and make it support Java 8 again?

sure. updated this pr to restore java 8 support

Copy link
Owner

@dadoonet dadoonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@dadoonet dadoonet merged commit 56cf81f into dadoonet:master Jul 5, 2021
@dadoonet dadoonet self-assigned this Jul 5, 2021
@dadoonet dadoonet added the update label Jul 5, 2021
@dadoonet dadoonet added this to the 7.x milestone Jul 5, 2021
@viqtor
Copy link
Contributor Author

viqtor commented Jul 22, 2021

@dadoonet you think this warrants a release? would be nice to have the new features with component templates and pipelines on a <jdk14 relase

@dadoonet
Copy link
Owner

It does indeed. I'll try to get this out in the next hours.

@dadoonet dadoonet changed the title restore java 8 Restore java 8 compatibility Jul 22, 2021
@dadoonet
Copy link
Owner

I just made the release. Thanks for the ping and the PR @viqtor ;)

https://discuss.elastic.co/t/announcement-elasticsearch-beyonder-7-13-2-released/279379

Please wait a bit until it's available on maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants