Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove tile before calling destroy #453
Conversation
SquidDev
referenced this pull request
Sep 15, 2017
Open
[WIP] Only instantiate ServerComputer on tile ticks #454
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SquidDev commentedSep 15, 2017
This ensures that the tile will updating neighbouring blocks, and so the destroyed tile will not be wrapped as a peripheral. This should avoid problems like those mentioned in #442 occurring again, but is no means a full solution to that problem - see the issue for more details.
I've done a pretty through read-through of the related code to ensure this won't break anything (#443 will occur with or without this patch), as well as testing this in-game. However, it's possible I've missed something, so any additional verification would be appreciated.