Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tile before calling destroy #453

Open
wants to merge 1 commit into
base: master
from

Conversation

@SquidDev
Copy link
Contributor

@SquidDev SquidDev commented Sep 15, 2017

This ensures that the tile will updating neighbouring blocks, and so the destroyed tile will not be wrapped as a peripheral. This should avoid problems like those mentioned in #442 occurring again, but is no means a full solution to that problem - see the issue for more details.

I've done a pretty through read-through of the related code to ensure this won't break anything (#443 will occur with or without this patch), as well as testing this in-game. However, it's possible I've missed something, so any additional verification would be appreciated.

This ensures that the tile will updating neighbouring blocks, and so
the destroyed tile will not be wrapped as a peripheral.
ccserver pushed a commit to ccserver/ComputerCraft that referenced this pull request Sep 16, 2019
…ager-remove-te

Remove tile before calling destroy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.