Remove tile before calling destroy #453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the tile will updating neighbouring blocks, and so the destroyed tile will not be wrapped as a peripheral.
ccserver
pushed a commit
to ccserver/ComputerCraft
that referenced
this pull request
Sep 16, 2019
…ager-remove-te Remove tile before calling destroy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the tile will updating neighbouring blocks, and so the destroyed tile will not be wrapped as a peripheral. This should avoid problems like those mentioned in #442 occurring again, but is no means a full solution to that problem - see the issue for more details.
I've done a pretty through read-through of the related code to ensure this won't break anything (#443 will occur with or without this patch), as well as testing this in-game. However, it's possible I've missed something, so any additional verification would be appreciated.