-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-width bars are one character too long #10
Comments
Thanks for the report @nedbat. That leading whitespace is indeed not supposed to be there. I'd definitely like to get to the bottom of this. However, it might require a bit of back and forth, because I haven't managed to reproduce it yet. The short version is that it's looking to me like your system, when it encounters the ANSI escape code at the beginning of the problematic lines, is causing some white space to be rendered (as if it were a space character), and also switching color as the ANSI code dictates. Whereas mine is just switching color. I've tried iTerm2 3.3.4, 3.3.3, 3.3.2. I haven't found a link to the beta that you're on yet. Could you perhaps try 3.3.4? Here's how the beginning of The main clue here seems to be that the problematic lines are the ones that start with an ANSI escape code; the initial line ("Theme: 1337") lacks any ANSI codes and starts in the first column for both of us.
The versions I've tried are: MacOS: 10.14.5 1 While the filename |
Hmm, I didn't think delta used less, but the problem seems to be my LESS environment variable. I have |
Ah, excellent, thanks for figuring that out. Yes, delta does spawn a |
A simple way to fix this would be to subtract one or two from the width for "full-width" bars. No one will care if they don't go quite to the right edge. |
OK, good call, I'll do that. (For any future readers of this issue, it was |
OK, this should be fixed in version 0.0.13. |
Using iterm2 Build 3.3.3beta2 on Mac 10.13.6. The bars that are meant to span the terminal are one character too long, and so wrap. It happens with --compare-themes as well as when being used as a pager:
Is the blank at the start of the line supposed to be there?
The text was updated successfully, but these errors were encountered: