Change API and structs to camelCase

[dani-garcia]

This PR changes all the project's structs and API inputs and outputs from the old PascalCase format to the new camelCase format. At the moment the clients support both but that won't be a thing forever.

I haven't had the time to fully test this, but at least the basic things work. There may be some things missing, and I still need to review what we store in the db to make sure that there aren't any backwards compat issues.

This might also cause problems with other pending PRs so we can wait to merge it until they are dealt with.

Some fields that have special casing:

• OTP in /accounts/verify-otp, as that's what the clients send. That said we also check otp
• Keys and Nfc in yubikey, this is for backwards compat with older values stored on the server, now we serialize new versions to keys and nfc.
• AttestationObject and clientDataJson in webauthn, as that's what the clients send. This is a bigger annoyance as it complicates the use of the webauthn crate.
• Organization policies, this is for backwards compat with older values stored on the server, now we serialize new versions as camelCase.

Fixes #4656

[BlackDex]

I still see a few non-camelCase key's in outputted JSON. For example in identity.rs
Ill check further but this was what is saw rather quickly.

[BlackDex]

Also, card vault types have SSN in there, that currently seems to be converted to sSN, which will probably break.

[BlackDex]

Also, not sure, but isn't it more useful to use fn convert_json_key_lcase_first from the utils mod? It might need some adjustments to also check for ssn maybe, but that should help with nested values stored in the database. And also for items like the Org Policies for example.

[quexten]

On this PR, and web 2024.05 confirming users to orgs does not work (I'm not sure if this is due to the PR, or due to the web vault changing), but since this is the same kind of issue it makes sense to solve here. Specifically, the body the web vault sends contains "key:", while the server expects "Key:" on the post body to /api/organizations/{orgid}/users/{userid}/confirm

[quexten]

Also, for native app compatibility, there seem to be some keys missing for organization profile responses, like

https://github.com/bitwarden/server/blob/b5241f1a9731ea74f22c2f4fe1072421f857429e/src/Api/AdminConsole/Models/Response/ProfileOrganizationResponseModel.cs#L157-L160

causing the native app(s) [only tested for iOS] to crash for accounts in an organization.

[quexten]

Also, somehow all custom fields in the sync response are null on this branch, (making custom fields inaccessible on all clients).

[dani-garcia]

@quexten Thanks for the review! I fixed the invalid case in key for the confirm and added the missing organization profile fields, which seems to work in both the new android and ios apps. The null fields should be also fixed with d5148bc, we were parsing the JSON incorrectly and ignoring the error.

@BlackDex I didn't even notice convert_json_key_lcase_first being there, but yeah I've switched it over in f0bf5bd, which required adding the check for ssn using _process_key (also removed some clones)

[dani-garcia]

Native apps are available in beta now, so we should try getting this merged soon:
https://fosstodon.org/@bitwarden/112639925158165590
https://community.bitwarden.com/t/about-the-beta-program/39185

[dani-garcia]

So far only bug remaining that I know of is that the Android app can't upload attachments or sends.

The android app sends a multipart/mixed header instead of the multipart/form-data header that the ios app and the rest of the clients send. I'll see if that's something we can change in the app.

Fixed in the latest main, uploads should work in the next beta update.

[BlackDex]

Ill see if i can do some more testing soon.

[BlackDex]

I just did some testing with my local accounts i use for debugging, and these are my findings so far.

• The admin UI doesn't work, the user and org overview are broken because the handlebar templates are not updated.
• For some reason in the Android Emulator i can't login at all, but that is not something we can fix i think.

On my physical phone (Pixel 7) it also doesn't work, i can login, but the sync fails on the client side.

• Sends have a text object which have the keys Hidden and Text those are still capital-case

  "text": {
      "Hidden": false,
      "Text": "2.j2Z/rN...TbjMvCQ==|/Kk0bfdc...68kv8A==|W1qbVban...AVJYYJRPy/WbK5iQeEQJIWwJh1k="
  }

• The same for Sends file:

  "file": {
      "FileName": "2.KcN9y...GuollclQ==|XxaO+KyT4fjIIYRb...MNxZ8VeHAAz4=|hruuM...PU4A=",
      "Id": "25587de08f158fe7ecfef24d22fc600c596efaf53bc5d7e23125e75c033a49bb",
      "Size": 10737,
      "SizeName": "10.49 KB"
  },

Other than that, i have not yet found anything which could be wrong any futher

[BlackDex]

Small update, Those sends were added via the PascalCase version of Vaultwarden.

[lukasj98]

I'm unable to download/view attachment on iOS beta app. Not sure if that's related though.

It is working perfect on iOS

[tonyxu-io]

I'm unable to download/view attachment on iOS beta app. Not sure if that's related though.

It is working perfect on iOS

I just tested again. It seems like image attachments works fine but PDF attachment doesn't work.

[BlackDex]

I'm unable to download/view attachment on iOS beta app. Not sure if that's related though.

It is working perfect on iOS

I just tested again. It seems like image attachments works fine but PDF attachment doesn't work.

PDF works fine for me too. it might be your phone which has issues with the attachment maybe? For me it just saves the files and i need to open it with a different app afterwards. So it doesn't matter what extension it is using.

[felixoswald]

Can confirm. PDF and other attachments work fine in the web interface (latest testing) and in the iOS beta app (2024.6.1 1151 @ iOS 18.0).

[ItsMelody]

Am I correct in understanding that we are now supposed to be able to connect to self-hosted Vaultwarden instances in the new Beta app of Bitwarden? Because I haven't had any updates on my docker container for Vaultwarden and it also still doesn't let me log in with the Beta app...

[tonyxu-io]

Am I correct in understanding that we are now supposed to be able to connect to self-hosted Vaultwarden instances in the new Beta app of Bitwarden? Because I haven't had any updates on my docker container for Vaultwarden and it also still doesn't let me log in with the Beta app...

You need to use testing branch.

#4386 (comment)

[magisk317]

I can log in to the beta version, but I can't sync/refresh the data. The log is as follows. Who can help me?

App prompt, "We are unable to process your request.Please try again or contact us."

[2024-07-07 05:01:27.691][request][INFO] GET /api/devices/knowndevice
[2024-07-07 05:01:27.693][response][INFO] (get_known_device) GET /api/devices/knowndevice => 200 OK
[2024-07-07 05:01:52.495][request][INFO] POST /identity/accounts/prelogin
[2024-07-07 05:01:52.497][response][INFO] (prelogin) POST /identity/accounts/prelogin => 200 OK
[2024-07-07 05:01:52.912][request][INFO] POST /identity/connect/token
[2024-07-07 05:01:53.040][vaultwarden::api::identity][INFO] User *****@***.com logged in successfully. IP: 10.0.0.20
[2024-07-07 05:01:53.040][response][INFO] (login) POST /identity/connect/token => 200 OK
[2024-07-07 05:01:54.079][request][INFO] GET /api/accounts/revision-date
[2024-07-07 05:01:54.082][response][INFO] (revision_date) GET /api/accounts/revision-date => 200 OK
[2024-07-07 05:01:54.089][request][INFO] GET /api/sync
[2024-07-07 05:01:54.133][response][INFO] (sync) GET /api/sync?<data..> => 200 OK
[2024-07-07 05:01:54.136][request][INFO] GET /api/ciphers/has-unassigned-ciphers
[2024-07-07 05:01:54.137][vaultwarden::api::core::ciphers][ERROR] Cipher doesn't exist
[2024-07-07 05:01:54.137][response][INFO] (get_cipher) GET /api/ciphers/<uuid> => 400 Bad Request
[2024-07-07 05:01:57.487][request][INFO] GET /api/accounts/revision-date
[2024-07-07 05:01:57.488][response][INFO] (revision_date) GET /api/accounts/revision-date => 200 OK
[2024-07-07 05:01:57.507][request][INFO] GET /api/sync
[2024-07-07 05:01:57.540][response][INFO] (sync) GET /api/sync?<data..> => 200 OK

Docker image version:

$ docker pull vaultwarden/server:testing
testing: Pulling from vaultwarden/server
Digest: sha256:c81f6915c14f748ea8a9025957aca421b884e818e849afea04e1ea06ece60622
Status: Image is up to date for vaultwarden/server:testing
docker.io/vaultwarden/server:testing

[BlackDex]

@magisk317 , then there might be something else in your data which either isn't correct and maybe we should fix, or something else strange.

Have you tried the latest mobile app version?
Try the latest build from the build workflow artifacts.
Android: https://github.com/bitwarden/android/actions/workflows/build.yml
iOS: https://github.com/bitwarden/ios/actions/workflows/build.yml

[magisk317]

@magisk317，那么您的数据中可能还存在其他不正确的内容，也许我们应该进行修复，或者存在其他奇怪的内容。

您尝试过最新的移动应用程序版本吗？ 尝试从构建工作流工件中获取最新版本。Android ： https: //github.com/bitwarden/android/actions/workflows/build.yml iOS：https: //github.com/bitwarden/ios/actions/workflows/build.yml

I tried, the phenomenon is the same, even the log is the same, but strangely, unofficial clients can be used normally, such as keyguard.

[BlackDex]

The new clients are more strict. So something in the output of the sync is causing issues. Unless we can see the output it would be hard for us to figure out out.

It probably is something in the data column in the ciphers table.
But it could be something else.

[ZerkerEOD]

Is there a fix for this? I just had my android app updated and as soon as I log in I am greeted with that message. I updated the backend and that didn't fix it for me.

[BlackDex]

@ZerkerEOD with what message? And what is the specific issue?
Did you updated to Vaultwarden v1.32.0?

[mhzawadi]

@ZerkerEOD can confirm that 1.32.0 does fix any issues with the new Bitwarden Beta app, make sure your running 1.32.0

[ZerkerEOD]

@ZerkerEOD with what message? And what is the specific issue? Did you updated to Vaultwarden v1.32.0?

The message is, "We were unable to process your request. Please try again or contact us." If I click try again it does the same thing. If I go to the Settings -> Other - There is no date for last sync and if I click the “Sync now” button it just goes into a sync that won't end unless I force close the app.

The server is showing version 1.32.0. Looks like the official bitwarden app is the cause as my vault works every where else. The app updated to the beta version finally and it started. So I left the beta and deleted and reinstalled and it looks like they pushed the beta into production.

[mhzawadi]

@ZerkerEOD Your very right, the old app is now the new Beta app. But both work for me, did you reset the data for the app?

[ZerkerEOD]

@ZerkerEOD Your very right, the old app is now the new Beta app. But both work for me, did you reset the data for the app?

I did, I first tried to delete cache and storage, then I deleted the application, left the beta, waited for that to register and then installed the app fresh again. Still doing the same thing.

[mhzawadi]

@ZerkerEOD Did you update your LB config to remove the WebSockets stuff?

[ZerkerEOD]

@ZerkerEOD Did you update your LB config to remove the WebSockets stuff?

To be honest, I never had any web socket informaiton in my load balancer stuff in my LB configs. I use Traefik for that and it has the following:

My web entry point automatically redirects everything to HTTPS also. So I could technically remove the web from the entry points.

[BlackDex]

It then must be some entry which is causing an issue.
You might want to try the debug android build which you can download from the release page in the Bitwarden repo on GitHub.

And then use adb to see if something there reports what the issue is. That would help us fix this.

Else you need to inspect the sync response manually and see if you see anything strange there compared to all other emtries.

[ZerkerEOD]

I will get to that hopefully later today if not this weekend. I am a little busy right now. I was able to get it working using Keyguard. But I do prefer the original app.

[ZerkerEOD]

@BlackDex, do you know what ADB commands would be needed? I have used it before to root my phones but that is about it.

[BlackDex]

well, first you need to install the -dev/-qa app, else no output will be shown at all.
But it seems it will only show the http requests/responses. No errors seem to appear at all in the logs.

So, you might still try. The command you are looking for is probably adb logcat.
Also see #4870, where there are some posts which describe on how to get some details.

[magisk317]

@BlackDex, do you know what ADB commands would be needed? I have used it before to root my phones but that is about it.

@ZerkerEOD I don't know if your problem has been solved? But my problem is still there...

@BlackDex I installed the dev version and grabbed the logcat, I don't know if it will be useful for this problem, if there is anything else that needs to be done, you can comment me

log.txt